Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SqlTestRunner to replace SqlTestsBase #18352

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Conversation

ziyuezh576
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@ziyuezh576 ziyuezh576 changed the title Sql Add SqlTestRunner to replace SqlTestsBase May 31, 2022
@ziyuezh576 ziyuezh576 added the Test Infra Test framework label Jun 2, 2022
.WithNewRmModules(helper => new[]
{
helper.RMProfileModule,
helper.RMStorageModule,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see Storage module. Please double confirm.

@vidai-msft vidai-msft assigned ziyuezh576 and unassigned vidai-msft Jun 3, 2022
@vidai-msft vidai-msft merged commit 0441386 into Azure:main Jun 10, 2022
@ziyuezh576 ziyuezh576 deleted the Sql branch June 15, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Infra Test framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants