Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KubernetesConfiguration-Flux] Move KubernetesConfiguration-Flux to main #18275

Merged
merged 5 commits into from
May 25, 2022

Conversation

lijinpei2008
Copy link
Contributor

@lijinpei2008 lijinpei2008 commented May 24, 2022

Description

  • Create Some cmdlets:
    • {Get}-AzKubernetesConfigFluxOperationStatus/AzK8sConfigFluxOperationStatus
    • {Get/New/Update/Remove}-AzKubernetesConfigurationFlux/AzK8sConfigurationFlux

Swagger : https://github.com/Azure/azure-rest-api-specs/tree/main/specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/stable/2022-03-01

Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1150

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@@ -18,6 +18,9 @@
- Additional information about change #1
-->
## Upcoming Release
* Create Some cmdlets:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Create Some cmdlets:
* Added cmdlets:
- `Get-AzKubernetesConfigFluxOperationStatus`
- `Get-AzKubernetesConfigurationFlux`
- `New-AzKubernetesConfigurationFlux`
- `Update-AzKubernetesConfigurationFlux`
- `Remove-AzKubernetesConfigurationFlux`


title: KubernetesConfiguration
module-version: 0.1.0
module-version: 0.6.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
module-version: 0.6.0
module-version: 0.1.0

@@ -121,7 +121,7 @@ PrivateData = @{
# IconUri = ''

# ReleaseNotes of this module
# ReleaseNotes = ''
ReleaseNotes = ' * Added cmdlets: * ''Get-AzKubernetesConfigFluxOperationStatus'' * ''Get-AzKubernetesConfigurationFlux'' * ''New-AzKubernetesConfigurationFlux'' * ''Update-AzKubernetesConfigurationFlux'' * ''Remove-AzKubernetesConfigurationFlux'''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@VeryEarly VeryEarly merged commit 0911701 into main May 25, 2022
@VeryEarly VeryEarly deleted the codegen/KubernetesConfiguration branch May 25, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants