StackHCI Registration process Improvements #18230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bniranjanbhat
changed the title
isra-fel
reviewed
May 20, 2022
added 4 commits
May 20, 2022 10:20
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
VeryEarly
approved these changes
May 24, 2022
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
bnichms
reviewed
May 24, 2022
| - Register-AzStackHCI cmdlet now does not take any action if required Resource Providers are already registered. This allows users with Roles who do not have permissions to register resource providers to still perform registration operation | ||
| * Supported for writing event log entries from registration cmdlets | ||
| - Register-AzStackHCI and UnRegister-AzStackHCI flows will now write events to Node log reflecting the status of registration. Events will be logged under source name "HCI Registration" | ||
| * Updated IMDS Cluster network |
There was a problem hiding this comment.
This change was already released in 1.1.1
bnichms
reviewed
May 24, 2022
| @@ -4689,16 +4771,26 @@ function New-Directory{ | |||
| #> | |||
| function Invoke-DeploymentModuleDownload{ | |||
| # Remote Support | |||
| New-Variable -Name RemoteSupportPackageUri -Value "https://remotesupportpackages.blob.core.windows.net/packages" -Option Constant -Scope Script | |||
| New-Variable -Name RemoteSupportPackageUri -Value "https://srsqldatasa.blob.core.windows.net/packages" -Option Constant -Scope Script | |||
There was a problem hiding this comment.
Do not bring this change over (or anything related to RS except for logging/etc).
bnichms
reviewed
May 25, 2022
| } | ||
|
|
||
| $ServiceEndpointAzureCloudFrontDoor = "https://azurestackhci.azurefd.net" | ||
| $ServiceEndpointAzureCloudFrontDoor = "https://dp.stackhci.azure.com" |
There was a problem hiding this comment.
Can you also bring over the Fairfax graph endpoint update?
$GraphServiceApiScopeAzureUSGovernment = "https://graph.windows.net/.default"
should change to
$GraphServiceApiScopeAzureUSGovernment = "https://graph.microsoft.us/.default"
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added