Add MonitorTestRunner to replace TestsController #18201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziyuezh576
commented
May 19, 2022
| { | ||
| // This allows the use of a particular subscription if the user is associated to several | ||
| // "TEST_CSM_ORGID_AUTHENTICATION=SubscriptionId=<subscription-id>" | ||
| string subId = Environment.GetEnvironmentVariable("TEST_CSM_ORGID_AUTHENTICATION"); |
There was a problem hiding this comment.
@vidai-msft Hi, I have a question about TestsController.cs#L133 and lines after it. Do they need to be kept or deleted? If delete, just like my current code, all tests can pass with Playback mode, but I don't know if they will make some tests fail when in Record mode.
There was a problem hiding this comment.
This is the by default way how a test environment is built in the TestEnvironmentFactory.GetTestEnvironment() method. So it is definitely duplicate code. Thanks!
vidai-msft
approved these changes
May 19, 2022
wyunchi-ms
added a commit
that referenced
this pull request
May 20, 2022
…#18247) * partition merge powershell cmdlet * Delete PartitionInfoGetResults * add pitr lite support * fix update continuoustier and tests * add test recording * Partition merge powershell cmdlets and tests * Add RedisCacheTestRunner and replace Controller (#18222) * Add PrivateDnsTestRunner and replace TestBase (#18202) * Add ReservationsTestRunner and replace TestController (#18226) * Add ResourceGraphTestRunner to replace TestController (#18227) * Signed-off-by: [email protected] <[email protected]> * Add ResourceGraphTestRunner to replace TestController * Add SecurityInsightsTestRunner and replace TestController (#18228) * Signed-off-by: [email protected] <[email protected]> (#18229) * Add ServiceFabricTestRunner and replace TestController (#18231) * Add SignalRTestRunner to replace TestController (#18232) * powershell changes * Add SupportTestRunner to replace TestController (#18188) * Add SupportTestRunner to replace TestController * Revert Az.Support document changes * Add SecurityTestRunner to replace TestController (#18189) * Add SecurityTestRunner to replace TestController * Revert Az.Security document changes * Add IotHubTestRunner to replace IotHubController (#18200) * Add MonitorTestRunner to replace TestsController (#18201) * Add TrafficManagerTestRunner to replace TestController (#18243) * Add more tests and fixes * Fix merge conflicts and documentation * revert non cosmosdb changes * Fix confirmation message * Update NuGet.Config * suppressions * Fix missing parameter * converted tests to manual verification Co-authored-by: Vinh Trinh <[email protected]> Co-authored-by: Yufan Yang <[email protected]> Co-authored-by: v-yuzhichen <[email protected]> Co-authored-by: Ziyue Zheng <[email protected]> Co-authored-by: Yunchi Wang <[email protected]>
8 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added