Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3 configs to config framework #18162

Merged
merged 5 commits into from
May 17, 2022
Merged

Added 3 configs to config framework #18162

merged 5 commits into from
May 17, 2022

Conversation

isra-fel
Copy link
Member

@isra-fel isra-fel commented May 15, 2022

Description

Includes the definition of the following configs:

  • DefaultSubscriptionForLogin
  • DisplayBreakingChangeWarnings
  • EnableDataCollection
    • Including how to migrate old settings to config framework
  • EnableSurvey (delayed)

And improvements to config framework and cmdlets:

  • Removed "-All" from Clear-AzConfig
  • Introduced src/shared/ConfigKeys.cs which is included in every service project so they can share the same definition for the keys.
  • Combined environment variable configs from different targets (machine, user, process) together because it's not distinguishable if an environment variable is set on which target.
    • By doing this, the priority of config providers becomes: Config (Process) > Environment Variable > Config (Current User)

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel force-pushed the yeming/use-config branch from b1e9ef3 to 04661e7 Compare May 15, 2022 22:56
@isra-fel isra-fel force-pushed the yeming/use-config branch from 04661e7 to 25267a4 Compare May 16, 2022 00:14
@isra-fel isra-fel marked this pull request as ready for review May 17, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants