Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataLakeAnalyticsTestRunner and replace AdlaTestsBase #18090

Merged
merged 2 commits into from
May 10, 2022

Conversation

CaptainFanZzz
Copy link
Contributor

Description

Add AdlaTestRunner and replace AdlaTestsBase.
Multiple Clients can't be removed.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@CaptainFanZzz CaptainFanZzz added the Test Infra Test framework label May 10, 2022
Copy link
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Rename from AdlaTestRunner to DataLakeAnalyticsTestRunner because only 1 test runner in each of the test project. So the name should be consistent with the test project name.
  2. AdlaTestRunner.ResourceGroupLocation is a const string. Remove this variable in the AdlaTestRunner.cs file and move it to the individual test page to decouple them.

@CaptainFanZzz CaptainFanZzz force-pushed the DataLakeAnalyticsTestRunner branch from b8cba74 to 55991d0 Compare May 10, 2022 10:43
@CaptainFanZzz CaptainFanZzz changed the title Add AdlaTestRunner and replace AdlaTestsBase Add DataLakeAnalyticsTestRunner and replace AdlaTestsBase May 10, 2022
@CaptainFanZzz CaptainFanZzz requested a review from vidai-msft May 10, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Infra Test framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants