Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ApplicationInsights] [BreakingChange] Replace applicationinsights cmdlet by autogen #18086

Merged
merged 7 commits into from
May 12, 2022

Conversation

VeryEarly
Copy link
Contributor

Description

Replace applicationinsights cmdlet by autogen, upgrade API version to 2020-02-02

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

VeryEarly and others added 7 commits May 9, 2022 20:28
* remove application insights handcrafted cmdlets

* suppress breaking messages

* remove applicationinsights.test

* mark test cases that reference applicationinsights as liveonly

* comment test cases for now
Comment on lines +33 to +49
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}

{{ Add output here }}
```

{{ Add description here }}

### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}

{{ Add output here }}
```

{{ Add description here }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the examples here.

Comment on lines +1 to +18
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}

{{ Add output here }}
```

{{ Add description here }}

### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}

{{ Add output here }}
```

{{ Add description here }}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the examples here.

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit 4597dd4 into main May 12, 2022
@VeryEarly VeryEarly deleted the codegen/ApplicationInsights branch May 12, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants