-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CognitiveServicesTestRunner and replace TestController #18077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to remove WithManagementClients method and make sure it has not impact on all the test casess
{"Microsoft.Authorization", null}, | ||
{"Microsoft.Network", null} | ||
} | ||
).WithManagementClients( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WithManagementClients method can be removed. Please make sure all tests can pass after removing it
return context.GetServiceClient<ResourceManagementClient>(RestTestFramework.TestEnvironmentFactory.GetTestEnvironment()); | ||
} | ||
|
||
private static CognitiveServicesManagementClient GetCognitiveServicesManagementClient(RestTestFramework.MockContext context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetCognitiveServiceManagementClient is not necessary. Please remove it.
return context.GetServiceClient<CognitiveServicesManagementClient>(RestTestFramework.TestEnvironmentFactory.GetTestEnvironment()); | ||
} | ||
|
||
protected NetworkManagementClient GetNetworkClient(RestTestFramework.MockContext context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetNetworkManagementClient is not necessary. Please remove it.
Description
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added