Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments in code to generate good XML file #18072

Merged
merged 1 commit into from
May 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Accounts/Accounts/Common/ScopeHelpers.cs
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,12 @@ public static ContextModificationScope GetContextModificationScopeForProcess(Deb
}

/// <summary>
/// Get the context modification scope for the current user. This will be 'Process' if changes should
/// only affect the current PowerShell session, or 'CurrentUser' if any changes should be global.
/// Get the context modification scope for the current user. This will be 'Process' if changes should
/// only affect the current PowerShell session, or 'CurrentUser' if any changes should be global.
/// </summary>
/// <param name="session"> The PowerShell session to be affected</param>
/// <param name="writer">A writer to write debug messages</param>
/// <returns>'Process' if all changes should only impact the current session, or 'CurrentUser' if
/// <returns>'Process' if all changes should only impact the current session, or 'CurrentUser' if
/// changes should be global.</returns>
public static ContextModificationScope GetContextModificationScopeForUser(IAzureSession session, DebugWriter writer)
{
Expand Down
16 changes: 8 additions & 8 deletions src/Accounts/Accounts/CommonModule/TelemetryProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -102,21 +102,21 @@ public static TelemetryProvider Create(bool collect, IEventStore store)
}

/// <summary>
/// Log a telemtry event
/// Log a telemetry event
/// </summary>
/// <param name="qosEvent">The event to log</param>
public virtual void LogEvent(string key)
/// <param name="qosEventKey">The event to log</param>
public virtual void LogEvent(string qosEventKey)
{
var dataCollection = _dataCollectionProfile.EnableAzureDataCollection;
var enabled = dataCollection.HasValue ? dataCollection.Value : true;

AzurePSQoSEvent qos;
if (this.TryGetValue(key, out qos))
AzurePSQoSEvent qosEvent;
if (this.TryGetValue(qosEventKey, out qosEvent))
{
qos.FinishQosEvent();
_helper.LogQoSEvent(qos, enabled, enabled);
qosEvent.FinishQosEvent();
_helper.LogQoSEvent(qosEvent, enabled, enabled);
_helper.FlushMetric();
this.Remove(key);
this.Remove(qosEventKey);
}
}

Expand Down