Add AnalysisServicesTestRunner and replace AsTestsBase #18056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziyuezh576
suggested changes
May 6, 2022
| { | ||
| helper.RMProfileModule, | ||
| helper.GetRMModulePath("Az.AnalysisServices.psd1"), | ||
| helper.GetRMModulePath("AzureRM.AnalysisServices.psd1") |
There was a problem hiding this comment.
same as the line above, delete it.
src/AnalysisServices/AnalysisServices.Test/InMemoryTests/DataPlaneCommandTests.cs
Outdated
Show resolved
Hide resolved
| # Visual Studio 15 | ||
| VisualStudioVersion = 15.0.27703.2042 | ||
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.1.32414.318 |
There was a problem hiding this comment.
don't edit solution file
| { | ||
| _logger = new XunitTracingInterceptor(output); | ||
| XunitTracingInterceptor.AddToContext(_logger); | ||
|
|
ziyuezh576
suggested changes
May 9, 2022
src/AnalysisServices/AnalysisServices.Test/InMemoryTests/DataPlaneCommandTests.cs
Outdated
Show resolved
Hide resolved
CaptainFanZzz
changed the title
ziyuezh576
suggested changes
May 10, 2022
src/AnalysisServices/AnalysisServices.Test/InMemoryTests/DataPlaneCommandTests.cs
Outdated
Show resolved
Hide resolved
CaptainFanZzz
force-pushed
the
AnalysisServicesTestRunner
branch
from
f8ddeaa to
d6f463c
Compare
ziyuezh576
previously approved these changes
May 10, 2022
vidai-msft
requested changes
May 13, 2022
| @@ -36,7 +36,7 @@ | |||
|
|
|||
| namespace Microsoft.Azure.Commands.AnalysisServices.Test.InMemoryTests | |||
| { | |||
| public class DataPlaneCommandTests : AsTestsBase | |||
| public class DataPlaneCommandTests : AnalysisServicesTestRunner | |||
There was a problem hiding this comment.
Please make it inherit from RMTestBase instead of TestRunner
vidai-msft
approved these changes
May 13, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add AnalysisServicesTestRunner and replace AzTestsBase
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added