Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventHub]: Deprecating MSI properties for breaking change release #18031

Merged
merged 13 commits into from
May 16, 2022

Conversation

damodaravadhani
Copy link
Member

Description

Deprecating older MSI properties from Set-AzEventHubNamespace and New-AzEventHubNamespace.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@wyunchi-ms
Copy link
Contributor

wyunchi-ms commented May 9, 2022

Please fix the breaking change exceptions and resolve the conflicts.

@damodaravadhani
Copy link
Member Author

Do you mean suppress the exceptions ? because we want these breaking changes in.

@wyunchi-ms
Copy link
Contributor

Do you mean suppress the exceptions ? because we want these breaking changes in.

Yes, and please resolve the conflicts.

@wyunchi-ms
Copy link
Contributor

Yes, you can append the exceptions throwed from static analysis to the BreakingChange.csv to pass the CI check.

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit b4d3d17 into Azure:main May 16, 2022
@damodaravadhani damodaravadhani deleted the deprecateMSI branch May 16, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants