Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HealthcareApis] move to generated codebase #18004

Merged
merged 4 commits into from
May 9, 2022
Merged

Conversation

isra-fel
Copy link
Member

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@lijinpei2008 lijinpei2008 marked this pull request as ready for review April 28, 2022 05:39
lijinpei2008
lijinpei2008 previously approved these changes Apr 28, 2022
Copy link
Contributor

@lijinpei2008 lijinpei2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@@ -98,7 +112,7 @@ PrivateData = @{
PSData = @{

# Tags applied to this module. These help with module discovery in online galleries.
Tags = 'Azure','ResourceManager','ARM','HealthCare','HealthcareApis','FhirService'
Tags = 'Azure','ResourceManager','ARM','PSModule','HealthcareApis'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Tags = 'Azure','ResourceManager','ARM','PSModule','HealthcareApis'
Tags = 'Azure','ResourceManager','ARM','PSModule','HealthcareApis'

Please update your generation PR and add the two missing tags back.
https://github.com/Azure/autorest.powershell/blob/main/docs/metadata.md

wyunchi-ms
wyunchi-ms previously approved these changes Apr 29, 2022
@isra-fel isra-fel marked this pull request as draft April 29, 2022 02:54
@isra-fel
Copy link
Member Author

Need time to investigate all the breaking changes.

@isra-fel isra-fel closed this May 9, 2022
@isra-fel isra-fel reopened this May 9, 2022
@isra-fel isra-fel marked this pull request as ready for review May 9, 2022 03:44
@isra-fel isra-fel merged commit 4b8c4e7 into main May 9, 2022
@isra-fel isra-fel deleted the codegen/HealthcareApis branch May 9, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants