Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Az.ContainerRegistry] fix parameter type for update-azcontainerregistryrepository #17984

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

VeryEarly
Copy link
Contributor

Description

$false was passed when optional parameter was not provided for type bool, change to bool? which reflect desired behavior.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms wyunchi-ms merged commit e761c69 into Azure:main Apr 29, 2022
@VeryEarly VeryEarly deleted the yabo/containerregistry branch May 30, 2022 02:08
@@ -28,19 +28,19 @@ public class UpdateAzureContainerRegistryRepository : ContainerRegistryDataPlane

[Parameter(Mandatory = false, HelpMessage = "Delete enable.")]
[ValidateNotNullOrEmpty]
public bool DeleteEnabled { get; set; }
public bool? DeleteEnabled { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why this breaking change was not detected, it causes other PR's CI failed. Could you have a look? @wyunchi-ms @VeryEarly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the breaking changes were not detected, and the CI ran suspeciously fast (azure-powershell - powershell-core
succeeded on 26 Apr in 17m 28s), I guess it was caused by the throtling of GitHub API, causing CI unable to get the list of changed files, so some of the steps were skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: The incorrect content on Remove-AzContainerRegistryTag
4 participants