Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Az.StackEdge Syntax Errors #17807

Merged
merged 3 commits into from
May 6, 2022
Merged

Fix Az.StackEdge Syntax Errors #17807

merged 3 commits into from
May 6, 2022

Conversation

v-yuzhichen
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@v-yuzhichen v-yuzhichen requested a review from ziyuezh576 April 14, 2022 09:54
ziyuezh576
ziyuezh576 suggested changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@ziyuezh576 ziyuezh576 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set-AzStackEdgeStorageAccountCredential.md
Remove-AzStackEdgeStorageAccountCredential.md
also need fixing.

src/StackEdge/StackEdge/help/New-AzStackEdgeBandwidthSchedule.md Outdated
@@ -33,7 +33,7 @@ The **New-AzStackEdgeBandwidthSchedule** cmdlet creates a new Bandwidth Schedule

### Example 1
```powershell
New-AzStackEdgeBandwidthSchedule -Days Sunday,Tuesday,Saturday -ResourceGroupName resourceGroupName -DeviceName deviceName -Name bandwidthSchedule -StartTime 11:00 -StopTime 12:00 -Bandwidth 30
New-AzStackEdgeBandwidthSchedule -DaysOfWeeky Sunday,Tuesday,Saturday -ResourceGroupName resourceGroupName -DeviceName deviceName -Name bandwidthSchedule -StartTime 11:00 -StopTime 12:00 -Bandwidth 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-DaysOfWeek

src/StackEdge/StackEdge/help/New-AzStackEdgeBandwidthSchedule.md Outdated
@@ -44,7 +44,7 @@ bandwidthSchedule Sunday, Tuesday, Saturday 30 11:00:00 12:00:00

### Example 2
```powershell
New-AzStackEdgeBandwidthSchedule -Days Sunday,Tuesday,Saturday -ResourceGroupName resourceGroupName -DeviceName deviceName -Name bandwidthScheduleUnlimited -StartTime 11:00 -StopTime 12:00 -UnlimitedBandwidth
New-AzStackEdgeBandwidthSchedule -DaysOfWeeky Sunday,Tuesday,Saturday -ResourceGroupName resourceGroupName -DeviceName deviceName -Name bandwidthScheduleUnlimited -StartTime 11:00 -StopTime 12:00 -UnlimitedBandwidth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-DaysOfWeek

src/StackEdge/StackEdge/help/New-AzStackEdgeRole.md Outdated
New-AzStackEdgeRole -ResourceGroupName resourceGroupName -DeviceName deviceName -Name iotrole -DeviceProperties
-IotDeviceId iotDeviceId -IotDeviceAccessKey iotAccessKey -IotEdgeDeviceId iotEdgeDeviceId -IotEdgeDeviceAccessKey iotEdgeDeviceAccessKey
-IotHostHub "ehub.azure-devices.net" -EncryptionKey @SecureString -Platform Linux -RoleStatus Enabled
New-AzStackEdgeRole -ResourceGroupName resourceGroupName -DeviceName deviceName -Name iotrole -DeviceProperty -IotDeviceId iotDeviceId -IotDeviceAccessKey iotAccessKey -IotEdgeDeviceId iotEdgeDeviceId -IotEdgeDeviceAccessKey iotEdgeDeviceAccessKey -IotHostHub "ehub.azure-devices.net" -EncryptionKey @SecureString -Platform Linux -RoleStatus Enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

New-AzStackEdgeRole -ResourceGroupName resourceGroupName -DeviceName deviceName -Name iotrole -DeviceProperty `
 -IotDeviceId iotDeviceId -IotDeviceAccessKey iotAccessKey -IotEdgeDeviceId iotEdgeDeviceId -IotEdgeDeviceAccessKey iotEdgeDeviceAccessKey `
 -IotHostHub "ehub.azure-devices.net" -EncryptionKey $SecureString -Platform Linux -RoleStatus Enabled

src/StackEdge/StackEdge/help/New-AzStackEdgeStorageAccountCredential.md Outdated
@@ -25,7 +25,7 @@ The **New-AzStackEdgeStorageAccountCredential** cmdlet creates a new edge storag

### Example 1
```powershell
New-AzStackEdgeStorageAccountCredential -ResourceGroupName resourceGroupName -DeviceName device-name -Name storage-acount-credential-name -StorageAccountName storageAccountName -StorageAccountType BlobStorage -StorageAccountAccessKey @SecureString -EncryptionKey @SecureString
New-AzStackEdgeStorageAccountCredential -ResourceGroupName resourceGroupName -DeviceName device-name -Name storage-acount-credential-name -StorageAccountCredentialName storageAccountName -StorageAccountType BlobStorage -StorageAccountAccessKey @SecureString -EncryptionKey @SecureString
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New-AzStackEdgeStorageAccountCredential -ResourceGroupName resourceGroupName -DeviceName deviceName -Name storageAccountName -StorageAccountType BlobStorage -StorageAccountAccessKey $SecureString -EncryptionKey $SecureString

@v-yuzhichen v-yuzhichen changed the title Az.StackEdge Syntax Errors Fix Az.StackEdge Syntax Errors Apr 27, 2022
@wyunchi-ms wyunchi-ms merged commit 70cae8b into Azure:main May 6, 2022
@isra-fel isra-fel mentioned this pull request May 26, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziyuezh576 ziyuezh576 ziyuezh576 approved these changes

Assignees

@ziyuezh576 ziyuezh576

Labels
Doc - Reference needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-yuzhichen @ziyuezh576 @wyunchi-ms