Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Az.OperationalInsights Syntax Errors #17733

Merged
merged 2 commits into from
May 7, 2022
Merged

Fix Az.OperationalInsights Syntax Errors #17733

merged 2 commits into from
May 7, 2022

Conversation

v-yuzhichen
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@v-yuzhichen v-yuzhichen requested a review from ziyuezh576 April 7, 2022 10:30
ziyuezh576
ziyuezh576 suggested changes Apr 12, 2022
View reviewed changes
...lInsights/OperationalInsights/help/New-AzOperationalInsightsApplicationInsightsDataSource.md Outdated
@@ -70,7 +70,7 @@ This command creates an application-insights data source of a given application

### Example 2: Get workspace object and create application-insights data source by the application resource id
```powershell
Get-AzureRmOperationalInsightsWorkspace -Name "MyWorkspace" -ResourceGroupName "ContosoResourceGroup" | New-AzOperationalInsightsApplicationInsightsDataSource -ApplicationResourceId "/subscriptions/e791a474-ee54-46a2-bb06-5e058302d234/resourceGroups/ContosoResourceGroup/providers/microsoft.insights/components/MyAIApplication"
Get-AzOperationalInsightsDeletedWorkspace -Name "MyWorkspace" -ResourceGroupName "ContosoResourceGroup" | New-AzOperationalInsightsApplicationInsightsDataSource -ApplicationResourceId "/subscriptions/e791a474-ee54-46a2-bb06-5e058302d234/resourceGroups/ContosoResourceGroup/providers/microsoft.insights/components/MyAIApplication"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "deleted" workspace?

@ziyuezh576 ziyuezh576 force-pushed the OperationalInsights-Syntax branch from 90e2b10 to 2d0b30d Compare April 27, 2022 11:15
@wyunchi-ms wyunchi-ms merged commit 78a154c into Azure:main May 7, 2022
@isra-fel isra-fel mentioned this pull request May 26, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziyuezh576 ziyuezh576 ziyuezh576 approved these changes

Assignees

@ziyuezh576 ziyuezh576

Labels
Doc - Reference needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-yuzhichen @ziyuezh576 @wyunchi-ms