Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources] Update Resources.ManagementGroups Module #17728

Merged
merged 32 commits into from
May 7, 2022

Conversation

git-thomasdolan
Copy link
Contributor

Description

  • Updated the ManagementGroups SDK to the latest version
  • Added and updated tests to test the new changes

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@ghost ghost added the customer-reported label Apr 6, 2022
@ghost
Copy link

ghost commented Apr 6, 2022

Thank you for your contribution git-thomasdolan! We will review the pull request and get back to you soon.

@git-thomasdolan git-thomasdolan changed the title Update Resources.ManagementGroups Module [Resources] Update Resources.ManagementGroups Module Apr 6, 2022
@git-thomasdolan git-thomasdolan marked this pull request as ready for review April 6, 2022 21:27
@git-thomasdolan
Copy link
Contributor Author

@dingmeng-xue Can someone review this? Thanks!

@isra-fel isra-fel self-assigned this Apr 13, 2022
@git-thomasdolan
Copy link
Contributor Author

Created issue here

… Removed the GetSubscriptionsUnderManagementGroup cmdlet and moved its functionality to GetManagementGroupSubscription. Renamed the DefaultMG parameter to DefaultManagementGroup and made its alias DefaultMG
@git-thomasdolan
Copy link
Contributor Author

Hi,

Are there any other changes I need to make? I believe I made all the requested changes from earlier. Thanks!

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants