[Az Eventgrid] Add new features for 2021-12-31 release #17608

rohkuma-microsoft · 2022-03-24T20:08:21Z

Description

New features as part of 2021-12-31 release.

Design :
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1115

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  - {Please put the link here}
- the markdown help files have been regenerated using the commands listed here

BethanyZhou

Please provide help markdown for new added cmdlets. Seems like the PR is in draft status. I set it as draft. Please feel free to set this PR as ready to review status

src/EventGrid/EventGrid/Models/PSSytemTopic.cs

src/EventGrid/EventGrid/SystemTopic/NewAzureEventGridSystemTopic.cs

BethanyZhou · 2022-03-25T02:47:27Z

src/EventGrid/EventGrid/SystemTopic/RemoveAzureEventGridSystemTopic.cs

+        public string ResourceGroupName { get; set; }
+
+        [Parameter(Mandatory = true,
+            ValueFromPipelineByPropertyName = true,


Need a -Force parameter for remove cmdlet

src/EventGrid/EventGrid/SystemTopic/UpdateAzureEventGridSystemTopic.cs

BethanyZhou

Please change parameter form to singularity
Please remove validate set for switch parameters.
please add -Force for remove-* cmdlet
Please keep the implementation align with design.

src/EventGrid/EventGrid/Domain/NewAzureEventGridDomain.cs

BethanyZhou · 2022-04-29T06:05:59Z

src/EventGrid/EventGrid/SystemTopic/GetAzureEventGridSystemTopic.cs

+    public class GetAzureRmEventGridSystemTopic : AzureEventGridCmdletBase
+    {
+        [Parameter(
+            Mandatory = false,


Why all parameters are optional? As we discussed before, in certain parameter set, some parameters should be required. Please confirm that

No, this is for getting system topics for a given subscription id. SubscriptionId is doesn't need to be separately passed as we get that from context.

BethanyZhou

Please check all MDs and fill placeholders.

BethanyZhou · 2022-05-05T02:04:56Z

src/EventGrid/EventGrid/help/Get-AzEventGridSystemTopic.md

+# Get-AzEventGridSystemTopic
+
+## SYNOPSIS
+{{ Fill in the Synopsis }}


Please fill all placeholders.

BethanyZhou · 2022-05-05T02:05:20Z

src/EventGrid/EventGrid/help/Get-AzEventGridSystemTopic.md

+```
+
+## DESCRIPTION
+{{ Fill in the Description }}


Please add description for cmdlets.

BethanyZhou · 2022-05-05T02:05:35Z

src/EventGrid/EventGrid/help/Get-AzEventGridSystemTopic.md

+## EXAMPLES
+
+### Example 1
+```powershell


A good example should be a good start for customer

BethanyZhou · 2022-05-05T02:07:19Z

src/EventGrid/EventGrid/help/Get-AzEventGridSystemTopic.md

+
+## NOTES
+
+## RELATED LINKS


It's nice to have if we can provide relate links.

BethanyZhou · 2022-05-05T02:09:03Z

For our pipeline checks, it said:

"Az.EventGrid","Microsoft.Azure.Commands.EventGrid.NewAzureEventGridSystemTopic","New-AzEventGridSystemTopic","1","8420","Parameter set 'SystemTopicNameParameterSet' of cmdlet 'New-AzEventGridSystemTopic' contains at least one parameter with a position larger than four, which is discouraged.","Limit the number of positional parameters in a single parameter set to four or fewer."

Please have a look.

BethanyZhou

Seems like you missed one comment: https://github.com/Azure/azure-powershell/pull/17608/files#r834912423, need a -Force parameter for remove cmdlet

BethanyZhou · 2022-05-06T01:38:56Z

src/EventGrid/EventGrid/SystemTopic/GetAzureEventGridFullUrlForSystemTopicEventSubscription.cs

+    [Cmdlet(
+        "Get",
+        ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "EventGridFullUrlForSystemTopicEventSubscription",
+        SupportsShouldProcess = true,


Get-* cmdlet should not support should process.

BethanyZhou · 2022-05-06T04:26:29Z

src/EventGrid/EventGrid/help/Update-AzEventGridSystemTopic.md

@@ -197,4 +196,5 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
 ## NOTES

 ## RELATED LINKS
+
 https://docs.microsoft.com/en-us/azure/event-grid/system-topics


Suggested change

https://docs.microsoft.com/en-us/azure/event-grid/system-topics

BethanyZhou · 2022-05-06T04:26:48Z

src/EventGrid/EventGrid/help/Remove-AzEventGridSystemTopicEventSubscription.md

+Default value: None
+Accept pipeline input: False
+Accept wildcard characters: False
+```

 ### -PassThru
 {{ Fill PassThru Description }}


Fill this description

BethanyZhou · 2022-05-06T04:26:56Z

src/EventGrid/EventGrid/help/Update-AzEventGridSystemTopicEventSubscription.md

@@ -367,4 +367,5 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
 ## NOTES

 ## RELATED LINKS
+
 https://docs.microsoft.com/en-us/azure/event-grid/system-topics


Suggested change

https://docs.microsoft.com/en-us/azure/event-grid/system-topics

BethanyZhou · 2022-05-06T04:29:33Z

src/EventGrid/EventGrid/help/Remove-AzEventGridSystemTopic.md

+```
+
+## DESCRIPTION
+{{ Fill in the Description }}


please have a look

BethanyZhou

LGTM

BethanyZhou · 2022-05-06T05:34:47Z

/azp run azure-powershell - security-tools

azure-pipelines · 2022-05-06T05:34:53Z

Azure Pipelines successfully started running 1 pipeline(s).

rohkuma-microsoft added 2 commits March 24, 2022 13:07

add new features

1adce5b

fix build issue

e48cdc3

BethanyZhou reviewed Mar 25, 2022

View reviewed changes

BethanyZhou marked this pull request as draft March 25, 2022 02:49

rohkuma-microsoft added 5 commits March 31, 2022 16:51

Adding addtional code

23d4228

Adding extra code

6556e1a

adding constants

19a5651

Fixing names of cmdlets

f2e801b

fix code bug and resolve a comment

fd8ed9a

BethanyZhou suggested changes Apr 29, 2022

View reviewed changes

BethanyZhou added the needs-revision label Apr 29, 2022

rohkuma-microsoft added 4 commits May 1, 2022 12:26

fixing pr comments

2f77a3b

Adding help files and fixing static analysis

6b74895

Adding session records

f58d8e0

Adding additional tests

8b10da8

BethanyZhou reviewed May 5, 2022

View reviewed changes

BethanyZhou marked this pull request as ready for review May 5, 2022 02:07

rohkuma-microsoft added 3 commits May 4, 2022 23:16

fixing system topic event subscription cmdlets

fa97930

Fix all the issues

050980d

Update help files

eee0c4c

BethanyZhou reviewed May 6, 2022

View reviewed changes

rohkuma-microsoft added 5 commits May 5, 2022 19:38

Updating the help files

23018aa

Remove should process from get cmdlets

160826a

Addressing pr comments

3a2fe5c

fix help

c1de5e2

Fix broken pipeline

745ca46

BethanyZhou reviewed May 6, 2022

View reviewed changes

Add missing values in help file

bcaff1e

BethanyZhou approved these changes May 6, 2022

View reviewed changes

BethanyZhou added Waiting for CI and removed needs-revision labels May 6, 2022

BethanyZhou merged commit 00e4082 into Azure:main May 6, 2022

isra-fel mentioned this pull request May 26, 2022

Fix exception import Az.Accounts caused by environment variables #18311

Closed

8 tasks

rohkuma-microsoft mentioned this pull request Aug 5, 2022

Add changelog for PR : 17608 #19151

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Az Eventgrid] Add new features for 2021-12-31 release #17608

[Az Eventgrid] Add new features for 2021-12-31 release #17608

rohkuma-microsoft commented Mar 24, 2022 •

edited

Loading

BethanyZhou left a comment

BethanyZhou Mar 25, 2022

rohkuma-microsoft May 6, 2022

BethanyZhou left a comment

BethanyZhou Apr 29, 2022

rohkuma-microsoft May 2, 2022

BethanyZhou left a comment

BethanyZhou May 5, 2022

rohkuma-microsoft May 6, 2022

BethanyZhou May 5, 2022

rohkuma-microsoft May 6, 2022

BethanyZhou May 5, 2022

rohkuma-microsoft May 6, 2022

BethanyZhou May 5, 2022

rohkuma-microsoft May 6, 2022

BethanyZhou commented May 5, 2022

BethanyZhou left a comment

BethanyZhou May 6, 2022

rohkuma-microsoft May 6, 2022

BethanyZhou May 6, 2022

BethanyZhou May 6, 2022

BethanyZhou May 6, 2022

BethanyZhou May 6, 2022

BethanyZhou left a comment

BethanyZhou commented May 6, 2022

azure-pipelines bot commented May 6, 2022

[Az Eventgrid] Add new features for 2021-12-31 release #17608

[Az Eventgrid] Add new features for 2021-12-31 release #17608

Conversation

rohkuma-microsoft commented Mar 24, 2022 • edited Loading

Description

Checklist

BethanyZhou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BethanyZhou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BethanyZhou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BethanyZhou commented May 5, 2022

BethanyZhou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BethanyZhou left a comment

Choose a reason for hiding this comment

BethanyZhou commented May 6, 2022

azure-pipelines bot commented May 6, 2022

rohkuma-microsoft commented Mar 24, 2022 •

edited

Loading