Update monitor cmdlet warning message #17129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingmeng-xue
previously approved these changes
Feb 16, 2022
|
Change log is required. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
VeryEarly
reviewed
Feb 17, 2022
| WriteWarningWithTimestamp(formattedMessage); | ||
| } | ||
| else | ||
| string supressWarningOrErrorValue = System.Environment.GetEnvironmentVariable(BreakingChangeAttributeHelper.SUPPRESS_ERROR_OR_WARNING_MESSAGE_ENV_VARIABLE_NAME); |
There was a problem hiding this comment.
please check line 96 - 101, remove duplicate logic.
There was a problem hiding this comment.
Done, please check it.
VeryEarly
reviewed
Feb 21, 2022
| { | ||
| WriteWarning(formattedMessage); | ||
| if (topic == "ExecuteCmdlet") |
There was a problem hiding this comment.
Suggested change
| if (topic == "ExecuteCmdlet") | |
| string formattedMessage = string.Format( | |
| CultureInfo.InvariantCulture, | |
| "{0}{1}{2}", | |
| string.IsNullOrEmpty(cmdletName)?cmdletName:"["+cmdletName+"] ", | |
| string.IsNullOrEmpty(topic)?topic:topic+": ", | |
| message); | |
| if (withTimeStamp) | |
| { | |
| WriteWarningWithTimestamp(formattedMessage); | |
| } | |
| else | |
| { | |
| WriteWarning(formattedMessage); | |
| } |
VeryEarly
reviewed
Feb 21, 2022
| WriteWarningWithTimestamp("The namespace for all the model classes will change from Microsoft.Azure.Management.Monitor.Management.Models to Microsoft.Azure.Management.Monitor.Models in future releases."); | ||
| WriteWarningWithTimestamp("The namespace for output classes will be uniform for all classes in future releases to make it independent of modifications in the model classes."); | ||
| } | ||
| this.WriteIdentifiedWarning( |
There was a problem hiding this comment.
WriteIdentifiedWarning("The namespace for all the model classes will change from Microsoft.Azure.Management.Monitor.Management.Models to Microsoft.Azure.Management.Monitor.Models in future releases.");
WriteIdentifiedWarning("The namespace for output classes will be uniform for all classes in future releases to make it independent of modifications in the model classes.");
Done |
|
It is good to me. |
VeryEarly
approved these changes
Feb 21, 2022
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update monitor cmdlet warning message
#17013 (comment)