-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual Wan P2S MultiPool feature changes #17032
Conversation
CI failed: The type or namespace name 'IConfigurationPolicyGroupsOperations' could not be found (are you missing a using directive or an assembly reference?) Please have a look. |
@@ -746,17 +760,17 @@ function Test-CortexExpressRouteCRUD | |||
Assert-AreEqual $vpnServerConfig1.Id $P2SVpnGateway.VpnServerConfiguration.Id | |||
Assert-AreEqual "Succeeded" $P2SVpnGateway.ProvisioningState | |||
Assert-AreEqual 1 @($P2SVpnGateway.CustomDnsServers).Count | |||
Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0] | |||
Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0] | |
Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0] |
$job = Reset-AzP2sVpnGateway -P2SVpnGateway $P2SVpnGateway -AsJob | ||
$job | Wait-Job | ||
$actual = $job | Receive-Job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct indents.
@isra-fel Incorporate review comment. Please take a look. |
Waiting for latest network SDK generation. |
Generally looks good. Please regenerate help documents and resolve the conflicts. |
Done. @isra-fel Please take a look. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file src/Network/Network/help/Az.Network.md
is supposed to be updated when introducing new cmdlets.
Please make sure to use -RefreshModulePage
when regenerating helps, see https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module
Let me update it. Thanks. |
Incorporated review comments & included latest test recording as well. @isra-fel Please take a look and help approve this PR. Thanks! |
… nilamd_network-2021-08-01
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be addedhttps://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1127