[NetAppFiles]Apply 2021-08-01 Changes #16855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Commenter does not have sufficient privileges for PR 16855 in repo Azure/azure-powershell |
wyunchi-ms
reviewed
Jan 19, 2022
| Mandatory = false, | ||
| HelpMessage = "If enabled, Traffic between the SMB server to Domain Controller (DC) will be encrypted.")] | ||
| [ValidateNotNullOrEmpty] | ||
| public SwitchParameter EncryptDCConnections { get; set; } |
There was a problem hiding this comment.
As PowerShell suggest use singularity for parameters. You can find doc here. Please rename Administrators to Administrator and EncryptDCConnections to EncryptDCConnection.
There was a problem hiding this comment.
hmm, some git issue, I will have a second look
There was a problem hiding this comment.
Is updating name of existing parameters allowed ?
There was a problem hiding this comment.
As your module is not GA yet. Is allowed.
src/NetAppFiles/NetAppFiles/ActiveDirectory/UpdateNetAppFilesActiveDirectory.cs
Show resolved
Hide resolved
|
@wyunchi-ms Updated |
wyunchi-ms
reviewed
Jan 20, 2022
src/NetAppFiles/NetAppFiles/help/New-AzNetAppFilesActiveDirectory.md
Outdated
Show resolved
Hide resolved
| Mandatory = false, | ||
| HelpMessage = "If enabled, Traffic between the SMB server to Domain Controller (DC) will be encrypted.")] | ||
| [ValidateNotNullOrEmpty] | ||
| public SwitchParameter EncryptDCConnections { get; set; } |
Do you push your commit? Please take a look at the status of CI pipeline. |
… ANF-16023-NetAppFiles-2021-08-01
…/audunn/azure-powershell into ANF-16023-NetAppFiles-2021-08-01
|
@wyunchi-ms git push solved and PR updated, thank you |
wyunchi-ms
approved these changes
Jan 24, 2022
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Azure NetApp Files to api-version 2021-01
API Specs
Azure/azure-rest-api-specs#17157
Azure/azure-rest-api-specs#16381
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added