-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated IoT Central .NET package to 4.0.0 (RP version 2021-06-01) with support for Managed Identities #16438
Conversation
…Identities Updated IoT Central Management Plane .Net package to 4.0.0. This version supports Managed Identities, removes support for S1 SKU, and supports only regional locations (not geographic). Related: .NET SDK update PR: Azure/azure-sdk-for-net#24992 Swagger update PR: Azure/azure-rest-api-specs#16139
@@ -19,6 +19,10 @@ | |||
--> | |||
## Upcoming Release | |||
|
|||
## Version 1.0.0 | |||
* Stable release version, updated to IoT Central .NET Management Plane SDK version 4.0.0. | |||
* This change introduces support for System-Assigned Managed Identities, adds support for regional locations like 'eastus' (while removing support for geographic locations like 'unitedstates'), and removes support for legacy S1 sku. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Support for regional locations is existing behavior in api version 2018-09-01, the only difference is deprecating support for geographical resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated changelog, thanks.
subdomain: this.Subdomain | ||
); | ||
|
||
if (!string.IsNullOrEmpty(this.Identity)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Say I have an existing application with a System Assigned Identity, if I run the PATCH command and don't specify anything for Identity, won't this get rid of my identity by going to the else
block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably just check if this.Identity has value
if it does, go ahead and change it
if it doesn't, do nothing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've removed the else and added validation on tests.
-InputObject <PSIotCentralApp> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] | ||
[<CommonParameters>] | ||
``` | ||
|
||
### InteractiveIotCentralParameterSet | ||
``` | ||
Set-AzIotCentralApp [-DisplayName <String>] [-Subdomain <String>] [-Tag <Hashtable>] [-Sku <String>] [-AsJob] | ||
Set-AzIotCentralApp [-DisplayName <String>] [-Subdomain <String>] [-Tag <Hashtable>] [-Sku <String>] [-Identity <String>] [-AsJob] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this work once we start supporting User Assigned Identities, what string would the user input here? The resourceId
of the User Assigned Identity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a separate model for user assigned identities. Per the swagger feedback from design team, when ready to support user-defined MI we should update the model in swagger (and then sdks) to use "MSI" (Managed System Identity model) which supports both System and User MIs. At this time to be specific and clear to users, only System assigned MI is supported just like our APIs.
Minor updates to tests and changelog
Updated test session records.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@isra-fel Please review and help merge it back into Azure repo. |
Looks you want to GA this module. Please follow the process of our guideline. |
Reverting module version and assembly version since they are computed per PR feedback.
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Description
Updated IoT Central Management Plane .Net package to 4.0.0, which references IoT Central's RP release v2021-06-01.
This update adds support for Managed Identities, removes support for S1 SKU, and allows calls using regional locations (migrating off geographic). Also updated models and tests for the new features.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added