Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated IoT Central .NET package to 4.0.0 (RP version 2021-06-01) with support for Managed Identities #16438

Merged
merged 6 commits into from
Nov 24, 2021

Conversation

gansvv
Copy link
Contributor

@gansvv gansvv commented Nov 18, 2021

Description

Updated IoT Central Management Plane .Net package to 4.0.0, which references IoT Central's RP release v2021-06-01.

This update adds support for Managed Identities, removes support for S1 SKU, and allows calls using regional locations (migrating off geographic). Also updated models and tests for the new features.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

gansvv and others added 2 commits November 18, 2021 06:41
…Identities

Updated IoT Central Management Plane .Net package to 4.0.0. This version supports Managed Identities, removes support for S1 SKU, and supports only regional locations (not geographic).

Related:
.NET SDK update PR: Azure/azure-sdk-for-net#24992
Swagger update PR: Azure/azure-rest-api-specs#16139
@gansvv gansvv changed the title Updated IoT Central .NET package to 4.0.0 with support for Managed Identities Updated IoT Central .NET package to 4.0.0 (RP version 2021-06-01) with support for Managed Identities Nov 18, 2021
@@ -19,6 +19,10 @@
-->
## Upcoming Release

## Version 1.0.0
* Stable release version, updated to IoT Central .NET Management Plane SDK version 4.0.0.
* This change introduces support for System-Assigned Managed Identities, adds support for regional locations like 'eastus' (while removing support for geographic locations like 'unitedstates'), and removes support for legacy S1 sku.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Support for regional locations is existing behavior in api version 2018-09-01, the only difference is deprecating support for geographical resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changelog, thanks.

r-delgadillo
r-delgadillo previously approved these changes Nov 18, 2021
subdomain: this.Subdomain
);

if (!string.IsNullOrEmpty(this.Identity))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say I have an existing application with a System Assigned Identity, if I run the PATCH command and don't specify anything for Identity, won't this get rid of my identity by going to the else block?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably just check if this.Identity has value
if it does, go ahead and change it
if it doesn't, do nothing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've removed the else and added validation on tests.

-InputObject <PSIotCentralApp> [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
[<CommonParameters>]
```

### InteractiveIotCentralParameterSet
```
Set-AzIotCentralApp [-DisplayName <String>] [-Subdomain <String>] [-Tag <Hashtable>] [-Sku <String>] [-AsJob]
Set-AzIotCentralApp [-DisplayName <String>] [-Subdomain <String>] [-Tag <Hashtable>] [-Sku <String>] [-Identity <String>] [-AsJob]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this work once we start supporting User Assigned Identities, what string would the user input here? The resourceId of the User Assigned Identity?

Copy link
Contributor Author

@gansvv gansvv Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a separate model for user assigned identities. Per the swagger feedback from design team, when ready to support user-defined MI we should update the model in swagger (and then sdks) to use "MSI" (Managed System Identity model) which supports both System and User MIs. At this time to be specific and clear to users, only System assigned MI is supported just like our APIs.

poanchen
poanchen previously approved these changes Nov 18, 2021
Minor updates to tests and changelog
@gansvv gansvv dismissed stale reviews from poanchen and r-delgadillo via 8cd4506 November 18, 2021 18:49
Updated test session records.
poanchen
poanchen previously approved these changes Nov 18, 2021
Copy link
Member

@poanchen poanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gansvv
Copy link
Contributor Author

gansvv commented Nov 18, 2021

@isra-fel Please review and help merge it back into Azure repo.

@isra-fel isra-fel self-assigned this Nov 22, 2021
wyunchi-ms
wyunchi-ms previously approved these changes Nov 23, 2021
poanchen
poanchen previously approved these changes Nov 23, 2021
@wyunchi-ms
Copy link
Contributor

Looks you want to GA this module. Please follow the process of our guideline.

src/IotCentral/IotCentral/Az.IotCentral.psd1 Outdated Show resolved Hide resolved
src/IotCentral/IotCentral/Properties/AssemblyInfo.cs Outdated Show resolved Hide resolved
Reverting module version and assembly version since they are computed per PR feedback.
@gansvv gansvv dismissed stale reviews from poanchen and wyunchi-ms via 63de737 November 23, 2021 17:45
@isra-fel
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@isra-fel isra-fel merged commit 093863f into Azure:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants