Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enable-subscription-id-overriding.md with limitations #15796

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

isra-fel
Copy link
Member

@isra-fel isra-fel commented Sep 1, 2021

Description

This PR adds a "Limitation" section to enable-subscription-id-overriding.md

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel changed the title Update enable-subscription-id-overriding.md Update enable-subscription-id-overriding.md with limitations Sep 1, 2021
@isra-fel
Copy link
Member Author

isra-fel commented Sep 1, 2021

Hi @BethanyZhou , please let me know if you think there's more worth adding.

@isra-fel isra-fel marked this pull request as ready for review September 1, 2021 08:35
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by far.

@BethanyZhou BethanyZhou merged commit b70510b into main Sep 2, 2021
@isra-fel isra-fel deleted the isra-fel-patch-1 branch September 2, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants