Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for pagination in Sql Get Databases #15772

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

harpaul-gill
Copy link
Contributor

@harpaul-gill harpaul-gill commented Aug 27, 2021

Description

Due to pagination being added into newer versions of the Sql list databases by server API we need to add support to the powershell cmdlet as well since currently users will only see the first 100 dbs when calling this on the new version

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@ghost ghost added the customer-reported label Aug 27, 2021
@ghost
Copy link

ghost commented Aug 27, 2021

Thank you for your contribution harpaul-gill! We will review the pull request and get back to you soon.

@VeryEarly VeryEarly self-assigned this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants