Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway Load Balancer inconsistency fix #15745

Merged
merged 3 commits into from
Aug 31, 2021
Merged

Gateway Load Balancer inconsistency fix #15745

merged 3 commits into from
Aug 31, 2021

Conversation

matyang22
Copy link
Contributor

@matyang22 matyang22 commented Aug 25, 2021

review PR https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1000

Description

`The new parameter was introduced here https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/898 but it also introduced some inconsistency.
This change is to fix inconsistency in 2 powershell commands.

image

One command(New-AzLoadBalancerBackendAddressPoolConfig) allows use of property TunnelInterface but the other command does not (New-AzLoadBalancerBackendAddressPool)

Adding the same parameter "TunnelInterface" to New-AzLoadBalancerBackendAddressPool and Set-AzLoadBalancerBackendAddressPool

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly self-assigned this Aug 25, 2021
Copy link
Contributor

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/azp run

@VeryEarly
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

VeryEarly
VeryEarly previously approved these changes Aug 27, 2021
@VeryEarly
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit 4920aca into Azure:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants