Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access error when subscripiton has no Tags property #15446

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

msJinLei
Copy link
Contributor

@msJinLei msJinLei commented Jul 9, 2021

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@msJinLei msJinLei changed the title Add tests for PSAzSubscription Fix the issue #15425 Jul 12, 2021
@msJinLei msJinLei marked this pull request as ready for review July 13, 2021 02:29
@msJinLei msJinLei changed the title Fix the issue #15425 Fix access error when subscripiton has no Tags property Jul 13, 2021
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After replacing local feeds we can merge it.
I'm OK with no changelog because last hotfix version already has it.

@dingmeng-xue
Copy link
Member

@msJinLei
Copy link
Contributor Author

Please add one test case to https://github.com/Azure/azure-powershell/blob/main/tools/Test/SmokeTest/RmCoreSmokeTests.ps1

Added

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msJinLei
Copy link
Contributor Author

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel merged commit a0149c9 into Azure:main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants