SQL Ledger Cmdlets #14974
Closed
SQL Ledger Cmdlets #14974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panant
reviewed
May 13, 2021
| /// </summary> | ||
| [Parameter(Mandatory = false, | ||
| HelpMessage = "The enable ledger option for the Azure Sql Database")] | ||
| public SwitchParameter EnableLedger { get; set; } |
There was a problem hiding this comment.
Since we don't allow alterting this, should this be part of the Set cmdlet?
src/Sql/Sql/LedgerDigestUploads/Cmdlet/AzureSqlDatabaseLedgerDigestUploadBase.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/LedgerDigestUploads/Cmdlet/AzureSqlDatabaseLedgerDigestUploadBase.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/LedgerDigestUploads/Cmdlet/EnableAzSqlDatabaseLedgerDigestUpload.cs
Show resolved
Hide resolved
src/Sql/Sql/LedgerDigestUploads/Model/AzureSqlDatabaseLedgerDigestLocationModel.cs
Show resolved
Hide resolved
rewongmicrosoft
requested review from
bilaakpan-ms,
dkulkarni-ms,
grizzlytheodore,
haagha,
madewithsmiles,
MikhailTryakhov,
MS-syh2qs and
Sandido
as code owners
rewongmicrosoft
force-pushed
the
rewongledger
branch
from
15a1724 to
e79386f
Compare
panant
reviewed
May 14, 2021
| .SYNOPSIS | ||
| Tests getting default ledger digest upload configuration | ||
| #> | ||
| function Test-GetDefaultLedgerDigestUpload |
There was a problem hiding this comment.
For the Get case, we don't have various parameter options:name, resourceID, etc.? Only for Set?
There was a problem hiding this comment.
Oh it seems like we do but you test everything in one test?
| $ledgerDigestUpload = Get-AzSqlDatabaseLedgerDigestUpload -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName | ||
|
|
||
| # Assert | ||
| Assert-AreEqual $ledgerDigestUpload.State "Disabled" |
There was a problem hiding this comment.
So we only test Get for Disabled? Are the other scenarios tested as part of the Set tests?
|
closed, use #14997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In progress PR for SQL Ledger cmdlets, see issue: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/929
See SDK change here: Azure/azure-sdk-for-net#21021
Swagger change here: https://github.com/Azure/azure-rest-api-specs/pull/13916/files, https://github.com/Azure/azure-rest-api-specs/pull/13871/files
Adds ledger cmdlets, and pipes IsLedgerOn property for database creation. Also updating naming in other resources to match changes in SDK. Currently testing with local SDK version, will update once new version is published.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added