Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Fabric] breaking changes deprecate cmdlets and parameters #14964

Merged
merged 9 commits into from
May 13, 2021

Conversation

a-santamaria
Copy link
Member

Description

Breaking changes for service fabric cmdlets

  • Remove deprecated cluster certificate commands:
    • Add-AzServiceFabricClusterCertificate
    • Remove-AzServiceFabricClusterCertificate
  • Change PSManagedService model to avoid using the properties parameter directly from sdk.
  • Remove deprecated parameters for managed cmdlets:
    • ReverseProxyEndpointPort
    • InstanceCloseDelayDuration
    • ServiceDnsName
    • InstanceCloseDelayDuration
    • DropSourceReplicaOnMove

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@a-santamaria a-santamaria added this to the S187 (2021-05-25) milestone May 12, 2021
@a-santamaria a-santamaria changed the title [Service Fabric] breaking changes [Service Fabric] breaking changes deprecate cmdlets and parameters May 12, 2021
@a-santamaria a-santamaria added the Breaking Change Release This PR contains breaking change label May 12, 2021
@a-santamaria
Copy link
Member Author

I added the exceptions for the expected breaking changes, but the static analysis is reporting removal of parameter sets which we didn't do. I'm not sure why they are showing up: https://dev.azure.com/azure-sdk/public/_build/results?buildId=891277&view=logs&j=b9afb22f-0837-5d02-bc24-6c30aee08bcf&t=990f6f37-4a21-5927-092a-220f38a460e9

@a-santamaria a-santamaria requested a review from LukeSlev May 12, 2021 22:38
@a-santamaria a-santamaria force-pushed the sf_breaking_changes branch from 1ae0132 to 430a6b3 Compare May 12, 2021 22:42
LukeSlev
LukeSlev previously approved these changes May 12, 2021
@wyunchi-ms wyunchi-ms merged commit d52d8b6 into Azure:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Release This PR contains breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants