Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automation] Fixed time zone issue while creating an update deployment schedule #14565

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

dmohanta
Copy link
Member

New-AzAutomationSoftwareUpdateConfiguration cmdlet is creating schedule by taking the UTC value as the StartTime instead of local time.

Description

New-AzAutomationSoftwareUpdateConfiguration cmdlet is creating schedule by taking the UTC value as the StartTime instead of local time.
When passing the start time and expiry time to the api, its converted to UTC, which the api assumes to be in local time and creates the suc accordingly.
Removing ToUniversalTime() in start time and expirty time while creating the suc object.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

…eating schedule by taking the UTC value as the StartTime instead of local time.
@BethanyZhou
Copy link
Contributor

Hi @dmohanta , please update changelod.md to describe the change you made in this pr.

assing
assing previously approved these changes Mar 19, 2021
@BethanyZhou
Copy link
Contributor

BethanyZhou commented Mar 22, 2021

Hi @aessing and @dmohanta , changelog.md should be updated before we merge this pr. It's required according to our development guideline: https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/azure-powershell-developer-guide.md#change-log

Updating ChangeLog.md
@dmohanta
Copy link
Member Author

Hi @dmohanta , please update changelod.md to describe the change you made in this pr.

Done.

@dmohanta
Copy link
Member Author

Hi @dmohanta , please update changelod.md to describe the change you made in this pr.

Done

@BethanyZhou BethanyZhou changed the title Bug 9534965: New-AzAutomationSoftwareUpdateConfiguration cmdlet is cr… [Automation] Fixed time zone issue while creating an update deployment schedule Apr 1, 2021
@BethanyZhou BethanyZhou merged commit 1c7c155 into master Apr 1, 2021
wyunchi-ms pushed a commit that referenced this pull request Apr 7, 2021
…t schedule (#14565)

* Bug 9534965: New-AzAutomationSoftwareUpdateConfiguration cmdlet is creating schedule by taking the UTC value as the StartTime instead of local time.

* Update ChangeLog.md

Updating ChangeLog.md

Co-authored-by: Debashish Mohanta <[email protected]>
@wyunchi-ms wyunchi-ms deleted the demoha/suc branch January 10, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants