Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TrafficSelectorPolicy param in VpnConnection for VWAN #14354

Merged
merged 10 commits into from
Mar 10, 2021

Conversation

akshatkale
Copy link
Contributor

@akshatkale akshatkale commented Feb 27, 2021

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/Network/Network/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@akshatkale
Copy link
Contributor Author

akshatkale commented Mar 1, 2021

Waiting for - https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/862

Edit - Cmdlet review is done.

Comment on lines +28 to +31
* Added new cmdlet to reset a Virtual Network Gateway Connection.
- `Reset-AzVirtualNetworkGatewayConnection`
* Added new cmdlet to reset a Vpn Site Link Connection.
- `Reset-VpnSiteLinkConnection`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These Reset changes were added in PR #14225 but ChangeLog in that PR was incorrect so fixed it.

@wyunchi-ms
Copy link
Contributor

LGTM

@akshatkale
Copy link
Contributor Author

@wyunchi-ms - I am not authorized to merge PRs in this repo. I think you'll have to merge it in.

@wyunchi-ms
Copy link
Contributor

Please resolve the conflicts.

@akshatkale
Copy link
Contributor Author

@wyunchi-ms Resolved. Please merge today once the checks pass. Also you might want to close the Cmdlet review https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/862 before merging this PR?

@wyunchi-ms wyunchi-ms merged commit e6fb94c into Azure:network-november Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants