-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to Get IKE Security Associations for VPN Site Link Connections #14182
Merged
+12,413
−21
Merged
Changes from 8 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8a906e0
Adding skeleton code
7c25fb4
Adding VpnLinkConnectionBaseCmdlet and formatting display for IKE SA
2b6b279
Bug fixes
2230240
Adding test
81cd50b
Update ChangeLog.md
580d636
Adding help file
726d0db
SDK support files
926d949
Merge branch 'network-november' into vpn-ikesa
4c9e307
Update Get-AzVpnSiteLinkConnectionIkeSa.md
5887042
Reverting Compute version
b1d7866
Changing Network version in other csproj files
bb55e15
Test bug fix
6920cd4
Update CredScanSuppressions.json
1f76297
Merge branch 'network-november' into vpn-ikesa
3e46a8d
Update CredScanSuppressions.json
1a7de9c
Sync network with master branch (#14198)
litchiyangMSFT e97b15b
Update CredScanSuppressions.json
4ec8542
Merge branch 'network-november' into vpn-ikesa
a4194cb
Update Get-AzVpnSiteLinkConnectionIkeSa.md
fde78f1
Update Get-AzVpnSiteLinkConnectionIkeSa.md
VeryEarly 03e3926
Revert "Merge branch 'network-november' into vpn-ikesa"
0a7da1b
Merge branch 'network-november' into vpn-ikesa
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might potentially have impact on other teams working on this branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Swagger was checked-in in the network-november-release. Until the official SDK is generated, the tests don't pass, right? I plan on reverting those files once that has been done if that's alright. Or I can revert it now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you recommend? @VeryEarly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the network SDK is fine, what I mean is the compute SDK.
It looks like a major version upgrade and it's possible that other test cases are not compatible with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway let's run the CI and see.