Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Pass principal type during role assignment put operations" #14103

Closed
wants to merge 8 commits into from
Closed

Revert "Pass principal type during role assignment put operations" #14103

wants to merge 8 commits into from

Conversation

dagoroz
Copy link
Contributor

@dagoroz dagoroz commented Feb 2, 2021

Reverts #13590

@VeryEarly VeryEarly self-assigned this Feb 3, 2021
@VeryEarly
Copy link
Contributor

Hi @dagoroz , any particular reason this need to be reverted?

@dingmeng-xue dingmeng-xue changed the base branch from master to release-2021-02-09 February 3, 2021 06:43
@dingmeng-xue
Copy link
Member

LGTM except changelog. I prefer that you just explain the change you did. For instance, removed (past tense is recommended) principal type on New-AzRoleAssignment and Set-AzRoleAssignment because …. (if there is any reason)

@dingmeng-xue dingmeng-xue added this to the S182 (2021-02-09) milestone Feb 3, 2021
@dagoroz
Copy link
Contributor Author

dagoroz commented Feb 3, 2021

@VeryEarly added you to the email thread

@VeryEarly
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor

Hi @dagoroz ,

Due to the Divergence of master branch (base branch of your PR) and release branch, I've created a new PR (from release branch and cherry-picked your commits).
#14122

@VeryEarly VeryEarly closed this Feb 4, 2021
@VeryEarly VeryEarly deleted the revert-13590-passPrincipalType branch August 16, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VeryEarly VeryEarly

Labels
needs-revision
Projects
None yet
Milestone
S182 (2021-02-09)
Development

Successfully merging this pull request may close these issues.
4 participants
@dagoroz @VeryEarly @dingmeng-xue @msJinLei