Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting IKE SA for List and Table views #13968

Merged
merged 6 commits into from
Jan 19, 2021
Merged

Conversation

abhi7860
Copy link
Member

@abhi7860 abhi7860 commented Jan 18, 2021

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@abhi7860 abhi7860 changed the base branch from master to release-2021-01-19 January 18, 2021 02:56
@abhi7860 abhi7860 requested a review from isra-fel January 18, 2021 02:56
@abhi7860 abhi7860 changed the title Formatting IKE SA Formatting IKE SA for List and Table views Jan 18, 2021
@abhi7860 abhi7860 marked this pull request as ready for review January 18, 2021 07:19
@abhi7860 abhi7860 changed the base branch from release-2021-01-19 to master January 18, 2021 07:24
@abhi7860 abhi7860 requested a review from isra-fel January 19, 2021 00:11
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isra-fel isra-fel merged commit d1f2aab into Azure:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants