Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some help files #13900

Merged
merged 11 commits into from
Jan 11, 2021
Merged

Rename some help files #13900

merged 11 commits into from
Jan 11, 2021

Conversation

Youri970410
Copy link
Contributor

@Youri970410 Youri970410 commented Jan 8, 2021

Description

Fix #13860
Rename some help files

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@isra-fel
Copy link
Member

isra-fel commented Jan 8, 2021

Why are some help files deleted?

@Youri970410
Copy link
Contributor Author

@isra-fel
Those cmdlets do not exist now so we need to remove the help files of them,"Az.ResourceGrap" is not fixed now.Here are a list for all cmdlets:

ServiceName Cmdlet Name Issue
Az.Aks Disable-AzAksAddon "On" is different from "on"
Az.Aks Enable-AzAksAddon "On" is different from "on"
Az.Compute Invoke-AzVmPatchAssessment "VM“ is different from "Vm"
Az.Network Disconnect-AzP2sVpnGatewayVpnConnection "S" is different from "s"
Az.Network Get-AzExpressRouteCrossConnectionARPTable "RP" is different from "pr"
Az.OperationalInsights Get-AzOperationalInsightsLinkTarget Alias Cmdlet and  Help file do not regenerate
Az.OperationalInsights Get-AzOperationalInsightsSavedSearchResult Alias Cmdlet and  Help file do not regenerate
Az.OperationalInsights Get-AzOperationalInsightsSearchResult Alias Cmdlet and  Help file do not regenerate
Az.ResourceGraph Search-AzGraph Do not exist in psd1
Az.Security DIsable-AzSecurityAdvancedThreatProtection "I" is different from "i"
Az.Sql Disable-AzSqlServerAdvancedThreatProtection Alias Cmdlet and  Help file do not regenerate
Az.Sql Enable-AzSqlServerAdvancedThreatProtection Alias Cmdlet and  Help file do not regenerate
Az.Storage Set-AzDataLakeGen2ItemACLObject "CL" is different from  "cl"

@Youri970410
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

This reverts commit 5e1df94.
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit bb63824 into Azure:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help mark down files cannot find its cmdlet implementation
2 participants