Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified SmokeTest/RmCoreSmokeTests.ps1. #13883

Merged
merged 7 commits into from
Jan 18, 2021

Conversation

LucasYao93
Copy link
Contributor

@LucasYao93 LucasYao93 commented Jan 6, 2021

Description

Modified SmokeTest/RmCoreSmokeTests.ps1.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou
Copy link
Contributor

@LucasYao93 It's suggested to run the smoke test script locally. And I think it's unnecessary to convert {Verb}-AzureRm{Noun} to {Verb}-Az{Noun} currently, could you revert these changes?

@LucasYao93
Copy link
Contributor Author

It's suggested to run the smoke test script locally. And I think it's unnecessary to convert {Verb}-AzureRm{Noun} to {Verb}-Az{Noun} currently, could you revert these changes?

Hi @BethanyZhou ,
I have ran the smoke test script locally which passed. Dingmeng suggested convert {Verb}-AzureRm{Noun} to {Verb}-Az{Noun}, Because the command format should be {Verb}-Az{Noun}.

Thanks

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable-AzureRmAlias handles {Verb}-AzureRm{Noun} as {Verb}-Az{Noun}, I'm okay to accept these conversions.

tools/Test/SmokeTest/RmCoreSmokeTests.ps1 Outdated Show resolved Hide resolved
tools/Test/SmokeTest/RmCoreSmokeTests.ps1 Show resolved Hide resolved
tools/Test/SmokeTest/RmCoreSmokeTests.ps1 Outdated Show resolved Hide resolved
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave one comment. Others LGTM

tools/Test/SmokeTest/RmCoreSmokeTests.ps1 Outdated Show resolved Hide resolved
BethanyZhou
BethanyZhou previously approved these changes Jan 8, 2021
@isra-fel
Copy link
Member

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@LucasYao93
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Leaved one comment.

@LucasYao93 LucasYao93 added this to the S182 (2021-02-09) milestone Jan 13, 2021
BethanyZhou
BethanyZhou previously approved these changes Jan 13, 2021
@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@dingmeng-xue dingmeng-xue merged commit 2ad4b83 into Azure:master Jan 18, 2021
@LucasYao93 LucasYao93 deleted the lucas/SmokeTest branch May 24, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants