-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified SmokeTest/RmCoreSmokeTests.ps1. #13883
Conversation
@LucasYao93 It's suggested to run the smoke test script locally. And I think it's unnecessary to convert {Verb}-AzureRm{Noun} to {Verb}-Az{Noun} currently, could you revert these changes? |
Hi @BethanyZhou , Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable-AzureRmAlias handles {Verb}-AzureRm{Noun} as {Verb}-Az{Noun}, I'm okay to accept these conversions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave one comment. Others LGTM
/azp run azure-powershell - powershell-core |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT. Leaved one comment.
/azp run azure-powershell - powershell-core |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Modified SmokeTest/RmCoreSmokeTests.ps1.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added