-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Cmdlet New-AzApplicationGatewayRewriteRuleUrlConfiguration to support url rewrite capability for V2 application gateways #10894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abjai, please see my inline comments. Thanks!
Oh and please also fix the merge conflict.
src/Network/Network/help/New-AzApplicationGatewayRewriteRuleUrlConfiguration.md
Outdated
Show resolved
Hide resolved
src/Network/Network/help/New-AzApplicationGatewayRewriteRuleUrlConfiguration.md
Outdated
Show resolved
Hide resolved
/azp run |
Pull request contains merge conflicts. |
@isra-fel I have addressed your comments. I have added the local feed so that tests can run. Once swagger SDK got published and updated in december-release branch, i will pull those changes and resolve the conflicts. Please note that we are targetting these changes to be released as a part of January end release. |
Hi @abjai |
@isra-fel : I have removed the conflict changes however i could see that SDK is still not updated in Network.csproj so tests might fail. @number213 : Can you please update the network.csproj with latest SDK so that tests start passing? Please note that these changes need to be part of Januray 20 release |
So, your test project still relies on 21.0.00preview SDK. |
@isra-fel : Yes it is still dependent on the updated SDK published as a part of January 17 release. I don't know the exact version published as a part of SDK release. Adding @number213 to help in updating the SDK version for Network.csproj |
@isra-fel @number213 has raised a PR to update SDK #10928. Once it is merged, my changes should be able to pass the tests |
@isra-fel : updated the PR with latest sdk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run azure-powershell - powershell-core |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-powershell - powershell-core |
Azure Pipelines successfully started running 1 pipeline(s). |
Need to work on PR for merging network into master. Since @isra-fel approved and added "waiting for CI" I'll go ahead and merge this PR |
Adding Cmdlet New-AzApplicationGatewayRewriteRuleUrlConfiguration to support url rewrite capability for V2 application gateways
Description
This should be released as a part of Powershell January Release
Adding Support for UrlConfiguration under RewriteRuleActionset for Application Gateway Url Rewrite Feature
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be addedPowershell design review link: Azure/azure-powershell-cmdlet-review-pr#339
Swagger PR: Azure/azure-rest-api-specs#7905