-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do Not Merge]Adding Cmdlet New-AzApplicationGatewayRewriteRuleUrlConfiguration to support url rewrite capability for V2 application gateways #10097
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
af5f11a
Add tooling documentation for Tools.Common, StaticAnalysis, and CI Fi…
cormacpayne 96210ce
Update documentation/tooling/ci-filter.md
cormacpayne 378abab
Merge pull request #9943 from cormacpayne/tooling-docs
erich-wang e363ecb
Adding Url Configuration Powershell cmdlet to support url rewrite in …
abjai 5da4d7d
adding tests
abjai 0007e27
Updating Test
abjai 0a9b366
Merge https://github.com/abjai/azure-powershell into dev/abjai/urlrew…
abjai d966db6
Test fix
abjai 8353929
Updating Test
abjai f604a59
Adding Playback json file
abjai ba43387
Reverting unwanted changes
abjai fd44643
reverting csproj file
abjai e47f8f1
Adding local sdk for building PR tests. Need to revert later
abjai e1a1699
Sai comment
abjai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7,805 changes: 7,805 additions & 0 deletions
7,805
...sts.ApplicationGatewayTests/TestApplicationGatewayCRUDRewriteRuleSetUrlConfiguration.json
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
...way/RewriteRuleUrlConfiguration/AzureApplicationGatewayRewriteRuleUrlConfigurationBase.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
// ---------------------------------------------------------------------------------- | ||
// | ||
// Copyright Microsoft Corporation | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// ---------------------------------------------------------------------------------- | ||
|
||
namespace Microsoft.Azure.Commands.Network | ||
{ | ||
using Microsoft.Azure.Commands.Network.Models; | ||
using System.Management.Automation; | ||
|
||
public class AzureApplicationGatewayRewriteRuleUrlConfigurationBase : NetworkBaseCmdlet | ||
{ | ||
[Parameter( | ||
Mandatory = false, | ||
HelpMessage = "Url path value.")] | ||
public string ModifiedPath { get; set; } | ||
|
||
[Parameter( | ||
Mandatory = false, | ||
HelpMessage = "Url query string value.")] | ||
public string ModifiedQueryString { get; set; } | ||
|
||
[Parameter( | ||
Mandatory = false, | ||
HelpMessage = "Flag to re-evaluate the url path map provided in path based request routing rules using modified path.")] | ||
public SwitchParameter Reroute { get; set; } | ||
|
||
public override void ExecuteCmdlet() | ||
{ | ||
base.ExecuteCmdlet(); | ||
} | ||
|
||
public PSApplicationGatewayUrlConfiguration NewObject() | ||
{ | ||
var urlConfiguration = new PSApplicationGatewayUrlConfiguration | ||
{ | ||
ModifiedPath = this.ModifiedPath, | ||
ModifiedQueryString = this.ModifiedQueryString, | ||
Reroute = this.Reroute.IsPresent | ||
}; | ||
|
||
return urlConfiguration; | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test your changes in existing test function like
ApplicationGatewayCRUDRewriteRuleSet
orApplicationGatewayCRUDSubItems
? I'm concerned that there are a lot of very similar tests in AppGw when each of them takes about 30 minutes to runThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For v2 gateways, any update should take maximum 5 mins. In this test, there are two create/update hence it will take maximum 10-12 minutes. You must be seeing 30 mins in the test cases when there are many creates/updates. We have around 20 mins time for V1 gateways so you might see high test running time for V1 gateways.
Is there any check in gate where these tests run in record mode? I won't mind adding each tests with different scenario if they are running locally only and check in gates run the playback tests.
I agree that there are many tests which can be merged into single test like RewriteRuleCRUD and RewriteRuleCRUDwithConditions. I think it would be better to open a work item on AppGW team to merge them and it should not be the part of this PR.
Apart from that, it would require making changes in the existing test cases which would require loop from the tests author itself to avoid any potential assert missing.