Remove Write-Host leaking file share credentials (#15225)

* Remove Write-Host leaking file share credentials Removed a Write-Host command that printed the Azure file share credentials when calling `New-AzContainerGroupVolumeObject` as reported in #15224. * Update Changelog.md Co-authored-by: Dingmeng Xue <[email protected]>
Azure · Jun 10, 2021 · f5899ca · f5899ca
1 parent ad5abea
commit f5899ca
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/src/ContainerInstance/Changelog.md b/src/ContainerInstance/Changelog.md
@@ -19,6 +19,7 @@
 -->
 
 ## Upcoming Release
+* Removed the display of file share credential [#15224]
 
 ## Version 2.0.0
 * Added new cmdlets: `Start-AzContainerGroup`, `Stop-AzContainerGroup` [#10773], `Invoke-AzContainerInstanceCommand` [#7648], `Update-AzContainerGroup`, `Add-AzContainerInstanceOutput`, `Get-AzContainerInstanceCachedImage`, `Get-AzContainerInstanceCapability`, `Get-AzContainerInstanceUsage`, `New-AzContainerGroupImageRegistryCredentialObject`, `New-AzContainerGroupPortObject`, `New-AzContainerGroupVolumeObject`, `New-AzContainerInstanceEnvironmentVariableObject`, `New-AzContainerInstanceInitDefinitionObject`, `New-AzContainerInstanceObject`, `New-AzContainerInstancePortObject` and `New-AzContainerInstanceVolumeMountObject`

diff --git a/src/ContainerInstance/custom/New-AzContainerGroupVolumeObject.ps1 b/src/ContainerInstance/custom/New-AzContainerGroupVolumeObject.ps1
@@ -70,7 +70,6 @@ function New-AzContainerGroupVolumeObject {
             $psTxt = . "$PSScriptRoot/../utils/Unprotect-SecureString.ps1" $PSBoundParameters['AzureFileStorageAccountKey']
         }
         $Object.AzureFileStorageAccountKey = $psTxt
-        Write-host $psTxt
         $Object.AzureFileStorageAccountName = $AzureFileStorageAccountName
         # $Object.EmptyDir = $EmptyDir
         $Object.GitRepoDirectory = $GitRepoDirectoryName