[SQL] Instance Link test changes (#18060)

* fix mi link test * align other tests
Azure · May 7, 2022 · a148908 · a148908
1 parent d040327
commit a148908
Show file tree

Hide file tree

Showing 4 changed files with 2,904 additions and 1,797 deletions.
diff --git a/src/Sql/Sql.Test/ScenarioTests/DistributedAvailabilityGroupTests.ps1 b/src/Sql/Sql.Test/ScenarioTests/DistributedAvailabilityGroupTests.ps1
@@ -58,13 +58,12 @@ function Test-ManagedInstanceLink
         Assert-Null $listLinksZero
 
         $upsertJ = New-AzSqlInstanceLink -ResourceGroupName $rgName -InstanceName $miName -LinkName $linkName -PrimaryAvailabilityGroupName $primaryAGName -SecondaryAvailabilityGroupName $secondaryAGName -TargetDatabase $targetDatabase -SourceEndpoint $sourceEndpoint -AsJob
+
+        # wait a little bit for the link resource to be created
+        Wait-Seconds 60
         $listResp = Get-AzSqlInstanceLink -ResourceGroupName $rgName -InstanceName $miName
-        $tries = 1
-        while ($listResp.Count -eq 0 -And $tries -le 5) {
-            $tries = $tries + 1
-            Wait-Seconds 30
-            $listResp = Get-AzSqlInstanceLink -ResourceGroupName $rgName -InstanceName $miName
-        }
+        Write-Debug ('$listLinksZero is ' + (ConvertTo-Json $listResp))
+        Assert-AreEqual $listResp.Count 1 # if this fails during recording, please increase Wait-Seconds duration (3 lines above)
 
         # Test all 4 parameter sets for GET:
         # GetByNameParameterSet
@@ -219,13 +218,12 @@ function Test-ManagedInstanceLinkErrHandling
 
         # upsert via CreateByParentObjectParameterSet
         $upsertJ = New-AzSqlInstanceLink -InstanceObject $instance -LinkName $linkName -PrimaryAvailabilityGroupName $primaryAGName -SecondaryAvailabilityGroupName $secondaryAGName -TargetDatabase $targetDatabase -SourceEndpoint $sourceEndpoint -AsJob
+
+        # wait a little bit for the link resource to be created
+        Wait-Seconds 60
         $listResp = Get-AzSqlInstanceLink -ResourceGroupName $rgName -InstanceName $miName
-        $tries = 1
-        while ($listResp.Count -eq 0 -And $tries -le 3) {
-            $tries = $tries + 1
-            Wait-Seconds 30
-            $listResp = Get-AzSqlInstanceLink -ResourceGroupName $rgName -InstanceName $miName
-        }
+        Write-Debug ('$listLinksZero is ' + (ConvertTo-Json $listResp))
+        Assert-AreEqual $listResp.Count 1 # if this fails during recording, please increase Wait-Seconds duration (3 lines above)
 
         # Link is created
         $getLink = Get-AzSqlInstanceLink -ResourceGroupName $rgName -InstanceName $miName -LinkName $linkName
@@ -302,13 +300,12 @@ function Test-ManagedInstanceLinkPiping
 
         # Upsert and get with parent instance Piping
         $upsertJ = $instance | New-AzSqlInstanceLink -LinkName $linkNamePipe -PrimaryAvailabilityGroupName $primaryAGNamePipe -SecondaryAvailabilityGroupName $secondaryAGNamePipe -TargetDatabase $targetDatabasePipe -SourceEndpoint $sourceEndpointPipe -AsJob
+
+        # wait a little bit for the link resource to be created
+        Wait-Seconds 60
         $listResp = $instance | Get-AzSqlInstanceLink
-        $tries = 1
-        while ($listResp.Count -eq 0 -And $tries -le 5) {
-            $tries = $tries + 1
-            Wait-Seconds 30
-            $listResp = $instance | Get-AzSqlInstanceLink
-        }
+        Write-Debug ('$listLinksZero is ' + (ConvertTo-Json $listResp))
+        Assert-AreEqual $listResp.Count 1 # if this fails during recording, please increase Wait-Seconds duration (3 lines above)
 
         $getLink = $instance | Get-AzSqlInstanceLink -LinkName $linkNamePipe
         Write-Debug ('$getLink is ' + (ConvertTo-Json $getLink))