Add MaintenanceTestRunner and replace TestController (#18151)

src/Maintenance/Maintenance.Test/ScenarioTests/MaintenanceTestRunner.cs

@@ -0,0 +1,56 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using System.Collections.Generic;
+using Microsoft.Azure.Commands.TestFx;
+using Xunit.Abstractions;
+
+namespace Microsoft.Azure.Commands.Maintenance.Test.ScenarioTests
+{
+    public class MaintenanceTestRunner
+    {
+        protected readonly ITestRunner TestRunner;
+
+        protected MaintenanceTestRunner(ITestOutputHelper output)
+        {
+            TestRunner = TestManager.CreateInstance(output)
+                .WithNewPsScriptFilename($"{GetType().Name}.ps1")
+                .WithProjectSubfolderForTests("ScenarioTests")
+                .WithCommonPsScripts(new[]
+                {
+                    @"Common.ps1",
+                    @"../AzureRM.Resources.ps1"
+                })
+                .WithNewRmModules(helper => new[]
+                {
+                    helper.RMProfileModule,
+                    helper.GetRMModulePath("Az.Maintenance.psd1")
+                })
+                .WithNewRecordMatcherArguments(
+                    userAgentsToIgnore: new Dictionary<string, string>
+                    {
+                        {"Microsoft.Azure.Management.Resources.ResourceManagementClient", "2016-02-01"}
+                    },
+                    resourceProviders: new Dictionary<string, string>
+                    {
+                        { "Microsoft.Resources", null },
+                        { "Microsoft.Features", null },
+                        { "Microsoft.Authorization", null },
+                        { "Microsoft.Maintenance", null }
+                    }
+                )
+                .Build();
+        }
+    }
+}

src/Maintenance/Maintenance.Test/ScenarioTests/MaintenanceTests.cs

@@ -12,59 +12,50 @@
 // limitations under the License.
 // ----------------------------------------------------------------------------------
 
-using Microsoft.Azure.Commands.ScenarioTest;
-using Microsoft.Azure.ServiceManagement.Common.Models;
 using Microsoft.WindowsAzure.Commands.ScenarioTest;
-using Microsoft.WindowsAzure.Commands.Test.Utilities.Common;
 using Xunit;
-using Xunit.Abstractions;
 
 namespace Microsoft.Azure.Commands.Maintenance.Test.ScenarioTests
 {
-    public class MaintenanceTests : RMTestBase
+    public class MaintenanceTests : MaintenanceTestRunner
     {
-        public XunitTracingInterceptor _logger;
-
-        public MaintenanceTests(Xunit.Abstractions.ITestOutputHelper output)
+        public MaintenanceTests(Xunit.Abstractions.ITestOutputHelper output) : base(output)
         {
-            _logger = new XunitTracingInterceptor(output);
-            XunitTracingInterceptor.AddToContext(_logger);
-            TestExecutionHelpers.SetUpSessionAndProfile();
         }
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestMaintenanceConfiguration()
         {
-            TestController.NewInstance.RunPowerShellTest(_logger, "Test-AzMaintenanceConfiguration");
+            TestRunner.RunTestScript("Test-AzMaintenanceConfiguration");
         }
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestMaintenanceConfigurationInGuestPatch()
         {
-            TestController.NewInstance.RunPowerShellTest(_logger, "Test-AzMaintenanceConfigurationInGuestPatch");
+            TestRunner.RunTestScript("Test-AzMaintenanceConfigurationInGuestPatch");
         }
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestConfigurationAssignment()
         {
-            TestController.NewInstance.RunPowerShellTest(_logger, "Test-AzConfigurationAssignment");
+            TestRunner.RunTestScript("Test-AzConfigurationAssignment");
         }
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestMaintenanceUpdate()
         {
-            TestController.NewInstance.RunPowerShellTest(_logger, "Test-AzMaintenanceUpdate");
+            TestRunner.RunTestScript("Test-AzMaintenanceUpdate");
         }
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestPublicMaintenanceConfiguration()
         {
-            TestController.NewInstance.RunPowerShellTest(_logger, "Test-AzMaintenancePublicConfiguration");
+            TestRunner.RunTestScript("Test-AzMaintenancePublicConfiguration");
         }
     }
 }