Updated Set-AzExpressRouteGateway to allow either one of `-MinScaleUn…

…its` and `-MaxScaleUnits` (#14150) * initial changes * suppress breaking change message * Update BreakingChangeIssues.csv Co-authored-by: Yabo Hu <[email protected]>
Azure · Feb 10, 2021 · 1cc74ba · 1cc74ba
1 parent cea4e1c
commit 1cc74ba
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/Network/Network/ChangeLog.md b/src/Network/Network/ChangeLog.md
@@ -20,6 +20,7 @@
 
 ## Upcoming Release
 * Updated format list and format table views for Get-AzVirtualNetworkGatewayConnectionIkeSa
+* Updated `set-azExpressRouteGateway` to allow parameter -MinScaleUnits without specifying -MaxScaleUnits
 
 ## Version 4.5.0
 * Added new cmdlets for CRUD of VpnGatewayNATRule.

diff --git a/src/Network/Network/Cortex/ExpressRouteGateway/SetAzureRmExpressRouteGatewayCommand.cs b/src/Network/Network/Cortex/ExpressRouteGateway/SetAzureRmExpressRouteGatewayCommand.cs
@@ -73,11 +73,13 @@ public class UpdateAzureRmExpressRouteGatewayCommand : ExpressRouteGatewayBaseCm
         [Parameter(
             Mandatory = false,
             HelpMessage = "Min for the scale units for this ExpressRouteGateway.")]
+        [ValidateRange(1, 100)]
         public uint MinScaleUnits { get; set; }
 
         [Parameter(
             Mandatory = false,
             HelpMessage = "Max for the scale units for this ExpressRouteGateway.")]
+        [ValidateRange(1, 100)]
         public uint MaxScaleUnits { get; set; }
 
         [Parameter(
@@ -116,7 +118,7 @@ public override void Execute()
                 throw new PSArgumentException(Properties.Resources.ExpressRouteGatewayNotFound);
             }
 
-            if (this.MinScaleUnits > 0 && this.MaxScaleUnits > 0)
+            if (this.MinScaleUnits > 0 || this.MaxScaleUnits > 0)
             {
                 if (this.MinScaleUnits > this.MaxScaleUnits)
                 {

diff --git a/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv b/tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv
@@ -1,2 +1,3 @@
 "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
-"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzFirewallPolicyNatRuleCommand","New-AzFirewallPolicyNatRule","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzFirewallPolicyNatRule' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzFirewallPolicyNatRule'."
+"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzFirewallPolicyNatRuleCommand","New-AzFirewallPolicyNatRule","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzFirewallPolicyNatRule' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzFirewallPolicyNatRule'."
+"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.UpdateAzureRmExpressRouteGatewayCommand","Set-AzExpressRouteGateway","0","2150","A validate range has been added for parameter 'MinScaleUnits' for cmdlet 'Set-AzExpressRouteGateway'.","Remove the validate range from parameter 'MinScaleUnits'."