Abstraction for config framework #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
commented
Mar 14, 2022
src/Authentication.Abstractions/Authentication.Abstractions.csproj
Outdated
Show resolved
Hide resolved
isra-fel
commented
Mar 14, 2022
src/Authentication.Abstractions/Authentication.Abstractions.csproj
Outdated
Show resolved
Hide resolved
isra-fel
commented
Mar 22, 2022
| /// The `invocation` parameter is typed `object` because we don't want Authentication.Abstractions project to take dependency on PowerShell SDK. | ||
| /// However at runtime it needs to be of type `InvocationInfo`.</remarks> | ||
| /// <returns>Value of the config, or the default value if never set.</returns> | ||
| T GetConfigValue<T>(string key, object invocation = null); |
There was a problem hiding this comment.
invocation was made an object type as we don't want to take dependency on the PowerShell SDK in the Authentication.Abstractions project, yet we still like to keep the simple syntax.
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <IncludeHyak>true</IncludeHyak> | |||
| <IsCmdletProject>false</IsCmdletProject> | |||
There was a problem hiding this comment.
@isral-fel, Is it still required?
There was a problem hiding this comment.
I'm not 100% sure if false = not specified, so let me just revert this csproj file.
dingmeng-xue
previously approved these changes
Mar 23, 2022
|
csproj is reverted. Please approve again @dingmeng-xue @BethanyZhou , thanks :) |
dingmeng-xue
approved these changes
Mar 23, 2022
BethanyZhou
approved these changes
Mar 23, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the abstractions of config framework.
The main interface is
IConfigManager, with abstract base classConfigDefinitionand a bunch of parameter and output types.