Update PatchPropertiesCorrespondToPutProperties to run in stagingOnly

[AkhilaIlla]

The LintDiff pipeline is failing with

{
  "pluginName": "spectral",
  "extensionName": "@microsoft.azure/openapi-validator",
  "level": "fatal",
  "message": "spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs pr/specification/resources/resource-manager/Microsoft.Resources/moboBrokers/preview/2023-06-01-preview/moboBrokers.json', error encountered: Error: Error running Nimma"
}

https://teams.microsoft.com/l/message/19:[email protected]/1695277014925?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=0cab4ce9-7691-42ae-82e3-460d4346a710&parentMessageId=1692914350538&teamName=ARM%20API%20Reviewers&channelName=ARM%20linter%20rules&createdTime=1695277014925
and hence the faulty rule is updated to run only in staging

[konrad-jamrozik]

@AkhilaIlla I think you should bump the ruleset package version. I am not blocking the PR as I will be away for few hours now, but please don't merge until you bump the package version.

https://github.com/Azure/azure-openapi-validator/blob/main/CONTRIBUTING.md#deploy-to-prod-lintdiff

N/A

[konrad-jamrozik]

This shouldn't be changed in this PR: the only changes are in packages/rulesets dir.

@AkhilaIlla Observe the dir layout:

And the names of the packages in the dirs:

You can also explore information about the published package versions on npm, e.g.:

https://www.npmjs.com/package/@microsoft.azure/openapi-validator-rulesets

This includes package dependencies. It helps to build a mental model.

Can you update the contributing guide to make the instructions clearer? Please add me as a reviewer.
#Resolved

[rkmanda]

Yup lets improve the doc so even first timers can cruise thru this.

[konrad-jamrozik]

This won't hurt, but strictly speaking there is no need for that, because of ^. https://semver.npmjs.com/

#Resolved

[AkhilaIlla]

You mean there isnt any necessity for ^ here right?
Also the latest version is 1.2.0 and now will be 1.2.1 and should this still be 1.1.*?

[konrad-jamrozik]

Observe the version is ^1.1.1. Which means it will accept anything of form 1.X.Y where X >= 1 and Y >= 1. So given you are changing ruleset from 1.2.0 to 1.2.1, it will pick it up. Also observe you are bumping it here from 1.1.1 to 1.1.2 but you changed the ruleset from 1.2.0 to 1.2.1.

[AkhilaIlla]

that makes sense. thanks so much!

[konrad-jamrozik]

This file change shouldn't be in this PR. #Resolved

[AkhilaIlla]

Builds fail without this file

[konrad-jamrozik]

It fails because there are changes to azure-openapi-validator/autorest/package.json. If you revert them (please do that) then it will pass.

[rkmanda]

🕐

[konrad-jamrozik]

I am curious, is this some leftover from previous change that was not generated into the .js file from .ts file? (that is, someone forgot to run all the steps from rush prep from step 4. here). Also, btw. rule name is lower-cased: trackedExtensionResourcesAreNotAllowed. Should be upper-cased. But we can fix it in another PR.

[konrad-jamrozik]

Left one non-blocking comment. Also would be nice to add some context in the PR description. Besides, looks good. Thx!

I verified the PR is good to go.

[rkmanda]

[konrad-jamrozik]

@AkhilaIlla now that the PR is merged, please follow the instructions here:

• https://github.com/Azure/azure-openapi-validator/blob/main/CONTRIBUTING.md#how-to-deploy-your-changes

I think at some point you will have to ping me to approve your prod release:

Once the build is complete, schedule a Prod npm release from that build. You may need to get an approval for the release from the appropriate Azure SDK EngSys team members.