Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to add an IpSecurityRestriction while Defining a WebApp #548

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dpetillo
Copy link

I needed this functionality added to the API. If it can be added to master, I think ill need advisement on my API signature(s) and how to properly regenerate the model:

src\ResourceManagement\AppService\Generated\Models\IpSecurityRestriction.cs

The copy in this commit was taken from https://github.com/Azure/azure-sdk-for-net and lightly modified.

@msftclas
Copy link

msftclas commented Dec 10, 2018

CLA assistant check
All CLA requirements met.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@hovsepm
Copy link
Contributor

hovsepm commented Dec 10, 2018

@azuresdkci test this please.

@praries880 praries880 self-assigned this Apr 4, 2019
@praries880 praries880 added App Services Mgmt Management plane SDK related issues. labels Apr 4, 2019
@@ -29,13 +21,30 @@ public IpSecurityRestriction()
/// Initializes a new instance of the IpSecurityRestriction class.
/// </summary>
/// <param name="ipAddress">IP address the security restriction is
/// valid for.</param>
/// valid for.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpetillo
you can undo these changes, The model got updated with these properties added to it :

public IpSecurityRestriction(string ipAddress = default(string), string subnetMask = default(string), string vnetSubnetResourceId = default(string), int? vnetTrafficTag = default(int?), int? subnetTrafficTag = default(int?), string action = default(string), IpFilterTag? tag = default(IpFilterTag?), int? priority = default(int?), string name = default(string), string description = default(string))

@praries880
Copy link
Contributor

@dpetillo
Thanks for the PR :)

We have already updated the models to include the changes you have here. We still need to add a public API to make IPSecurityRestriction available on the Fluent API though. We will get try to get the suggestions here in webapps in the near future.

The API changes you made do look good, but we still have to look into the update (PATCH) scenario and add tests for the same.

@yaohaizh yaohaizh requested a review from ChenTanyi October 11, 2019 06:44
@yaohaizh
Copy link

@ChenTanyi please follow with this PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Services Mgmt Management plane SDK related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants