-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to add an IpSecurityRestriction while Defining a WebApp #548
base: master
Are you sure you want to change the base?
Add API to add an IpSecurityRestriction while Defining a WebApp #548
Conversation
Can one of the admins verify this patch? |
@azuresdkci test this please. |
@@ -29,13 +21,30 @@ public IpSecurityRestriction() | |||
/// Initializes a new instance of the IpSecurityRestriction class. | |||
/// </summary> | |||
/// <param name="ipAddress">IP address the security restriction is | |||
/// valid for.</param> | |||
/// valid for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dpetillo
you can undo these changes, The model got updated with these properties added to it :
azure-libraries-for-net/src/ResourceManagement/AppService/Generated/Models/IpSecurityRestriction.cs
Line 51 in 303240f
public IpSecurityRestriction(string ipAddress = default(string), string subnetMask = default(string), string vnetSubnetResourceId = default(string), int? vnetTrafficTag = default(int?), int? subnetTrafficTag = default(int?), string action = default(string), IpFilterTag? tag = default(IpFilterTag?), int? priority = default(int?), string name = default(string), string description = default(string)) |
@dpetillo We have already updated the models to include the changes you have here. We still need to add a public API to make IPSecurityRestriction available on the Fluent API though. We will get try to get the suggestions here in webapps in the near future. The API changes you made do look good, but we still have to look into the update (PATCH) scenario and add tests for the same. |
@ChenTanyi please follow with this PR. Thanks. |
I needed this functionality added to the API. If it can be added to master, I think ill need advisement on my API signature(s) and how to properly regenerate the model:
src\ResourceManagement\AppService\Generated\Models\IpSecurityRestriction.cs
The copy in this commit was taken from https://github.com/Azure/azure-sdk-for-net and lightly modified.