support webapp windows container #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidongxu-microsoft
requested review from
ChenTanyi,
xseeseesee and
yungezz
as code owners
Comment on lines
173
to
185
| var appServicePlan = appServiceManager.AppServicePlans | ||
| .Define(AppServicePlanName1) | ||
| .WithRegion(Region.USEast) | ||
| .WithNewResourceGroup(GroupName1) | ||
| .WithPricingTier(PricingTier.PremiumP1v3) | ||
| .WithOperatingSystem(OperatingSystem.Windows) | ||
| .Create(); | ||
|
|
||
| var webApp = appServiceManager.WebApps.Define(WebAppName1) | ||
| .WithExistingWindowsPlan(appServicePlan) | ||
| .WithExistingResourceGroup(GroupName1) | ||
| .WithPublicDockerHubImage("mcr.microsoft.com/azure-app-service/samples/aspnethelloworld:latest") | ||
| .Create(); |
There was a problem hiding this comment.
Serve as sample as well.
From Portal, web app with windows docker seems had to use PremiumP1v3 or higher.
|
No pipelines are associated with this pull request. |
|
No pipelines are associated with this pull request. |
|
No pipelines are associated with this pull request. |
ChenTanyi
approved these changes
Oct 12, 2020
| @@ -156,5 +156,43 @@ public void WebAppWithoutPhp() | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void CanCRUDWebAppWithContainer() | |||
There was a problem hiding this comment.
may be better ...WithWindowsContainer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1146