Fixed bug where nested json inside pandas wouldn't be ingested correctly #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohadbitt
reviewed
Feb 18, 2025
| @@ -117,12 +115,11 @@ def ingest_from_dataframe(self, df: "pandas.DataFrame", ingestion_properties: In | |||
| if not isinstance(df, DataFrame): | |||
| raise ValueError("Expected DataFrame instance, found {}".format(type(df))) | |||
|
|
|||
| file_name = "df_{id}_{timestamp}_{uid}.csv.gz".format(id=id(df), timestamp=int(time.time()), uid=uuid.uuid4()) | |||
| file_name = "df_{id}_{timestamp}_{uid}.json.gz".format(id=id(df), timestamp=int(time.time()), uid=uuid.uuid4()) | |||
There was a problem hiding this comment.
this is a breaking change - as this wont work the same for users who configured csv mapping
There was a problem hiding this comment.
That's a good point, but before we had:
ingestion_properties.format = DataFormat.CSV
So if a user used a different format mapping it wouldn't work.
I can roll it in the next breaking version (with a comment on the release notes),
Or I can check for a mapping and error? Or if the format doesn't match error?
I don't think we can get around not converting it to json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #567