Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resource uri hostname parsing #231

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

alonadam
Copy link
Contributor

1)Don't parse resource Uri to avoid taking dependency on its structure
2)Keep original error when ingestion resources fail to refresh

@alonadam alonadam requested a review from AsafMah March 31, 2024 10:55
Copy link

github-actions bot commented Mar 31, 2024

Test Results

478 tests   478 ✅  28m 42s ⏱️
 26 suites    0 💤
  1 files      0 ❌

Results for commit 392f25e.

♻️ This comment has been updated with latest results.

@alonadam alonadam force-pushed the remove-resource-uri-hostname-parsing branch from 3dedc8b to 0134748 Compare March 31, 2024 11:22
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (v0.x@88f8d7e). Click here to learn what that means.

Files Patch % Lines
kusto/ingest/internal/resources/resources.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v0.x     #231   +/-   ##
=======================================
  Coverage        ?   49.30%           
=======================================
  Files           ?       70           
  Lines           ?     8823           
  Branches        ?        0           
=======================================
  Hits            ?     4350           
  Misses          ?     4128           
  Partials        ?      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonadam alonadam merged commit ed700aa into v0.x Mar 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants