Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource mgr keep original error #228

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Conversation

alonadam
Copy link
Contributor

1.return original error when failing to refresh ingestion resources.
2.fix resource URI parsing for URI with long hostname.

@alonadam alonadam requested review from ohadbitt and AsafMah March 28, 2024 14:15
Copy link

github-actions bot commented Mar 28, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 12bb90e. ± Comparison against base commit 11658ef.

♻️ This comment has been updated with latest results.

@alonadam alonadam force-pushed the resource-mgr-keep-original-error branch 3 times, most recently from d631e7c to 4ed887b Compare March 28, 2024 15:41
@alonadam alonadam force-pushed the resource-mgr-keep-original-error branch from 4ed887b to 12bb90e Compare March 28, 2024 15:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.12%. Comparing base (11658ef) to head (12bb90e).

Files Patch % Lines
azkustoingest/internal/resources/resources.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   54.26%   54.12%   -0.14%     
==========================================
  Files          70       70              
  Lines        5621     5598      -23     
==========================================
- Hits         3050     3030      -20     
+ Misses       2345     2343       -2     
+ Partials      226      225       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AsafMah AsafMah merged commit 17aa3a7 into master Mar 31, 2024
6 checks passed
@AsafMah AsafMah deleted the resource-mgr-keep-original-error branch March 31, 2024 10:57
t-ronmoneta pushed a commit that referenced this pull request Apr 8, 2024
Resolved confilcts, took local

* keep original error

* Fix uri parsing for usnat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants