User/ohbitton/add file options #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/azure-kusto-go into user/ohbitton/addFileOptions
…re/azure-kusto-go into user/ohbitton/addFileOptions
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 51.49% 52.20% +0.70%
==========================================
Files 53 53
Lines 5872 5888 +16
==========================================
+ Hits 3024 3074 +50
+ Misses 2632 2595 -37
- Partials 216 219 +3 ☔ View full report in Codecov by Sentry. |
AsafMah
requested changes
Nov 16, 2023
kusto/ingest/source/source.go
Outdated
| case ZIP: | ||
| return "zip" | ||
| } | ||
| return "unknown compression type" |
There was a problem hiding this comment.
Difference between none & unknown?
There was a problem hiding this comment.
yes
not mine but usefull
AsafMah
reviewed
Dec 3, 2023
AsafMah
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
RawDataSize, CompressionType file options
copilot:all