Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future version 1.0 #180

Merged
merged 81 commits into from
Mar 11, 2024
Merged

Future version 1.0 #180

merged 81 commits into from
Mar 11, 2024

Conversation

AsafMah
Copy link
Contributor

@AsafMah AsafMah commented Apr 30, 2023

Changed

  • [BREAKING] [MAJOR] Split the main module into two packages:
    • azkustodata - contains querying, management and commands.
    • azkustoingest - contains ingestion in all its forms.
  • [BREAKING] Minimum Go version is now 1.20.

@github-actions
Copy link

github-actions bot commented Apr 30, 2023

Test Results

0 tests   - 481   0 ✅  - 481   0s ⏱️ - 28m 40s
0 suites  -  26   0 💤 ±  0 
0 files    -   1   0 ❌ ±  0 

Results for commit 69d61d1. ± Comparison against base commit b27ad23.

♻️ This comment has been updated with latest results.

@AsafMah AsafMah marked this pull request as draft April 30, 2023 11:19
@AsafMah AsafMah marked this pull request as ready for review April 30, 2023 11:28
AsafMah added 4 commits April 30, 2023 14:30
# Conflicts:
#	azkustodata/utils/transporter.go
#	azkustoingest/test/etoe/etoe_test.go
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Attention: Patch coverage is 60.10795% with 813 lines in your changes are missing coverage. Please review.

Project coverage is 54.15%. Comparing base (b27ad23) to head (69d61d1).

Files Patch % Lines
azkustodata/query/row_impl.go 25.46% 114 Missing and 6 partials ⚠️
azkustodata/kusto.go 40.36% 89 Missing and 10 partials ⚠️
azkustodata/value/value.go 20.00% 67 Missing and 1 partial ⚠️
azkustodata/query/v2/iteartive_dataset.go 68.75% 52 Missing and 13 partials ⚠️
azkustodata/errors/errors.go 0.00% 56 Missing ⚠️
azkustodata/query/v1/dataset.go 56.96% 25 Missing and 9 partials ⚠️
azkustodata/value/decimal.go 30.43% 29 Missing and 3 partials ⚠️
azkustodata/value/timespan.go 30.76% 27 Missing ⚠️
azkustodata/query/v2/iterative_table.go 76.53% 16 Missing and 7 partials ⚠️
azkustoingest/test/etoe/etoe_env.go 53.06% 17 Missing and 6 partials ⚠️
... and 34 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   49.40%   54.15%   +4.75%     
==========================================
  Files          70       70              
  Lines        8846     5621    -3225     
==========================================
- Hits         4370     3044    -1326     
+ Misses       4130     2350    -1780     
+ Partials      346      227     -119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AsafMah added 12 commits May 10, 2023 11:32
# Conflicts:
#	CHANGELOG.md
#	azkustodata/mgmtopts.go
#	azkustodata/queryopts.go
#	quickstart/go.mod
- azidentity package dependency

### Changed
- Update azkustoingest/test/etoe/etoe_test.go to use azkustoingest.FileOption

### Fixed

### Removed

### Security
# Conflicts:
#	CHANGELOG.md
#	azkustodata/utils/once_test.go
AsafMah and others added 10 commits July 19, 2023 11:35
# Conflicts:
#	azkustodata/kcsb.go
#	azkustoingest/go.mod
#	azkustoingest/go.sum
* * [BREAKING] [MAJOR] Constructing ingest clients is now done using a KustoConnectionStringBuilder, and not a client struct.
* In addition, passing a default database and table for ingestion is not necessary anymore, and can be done using Options.
   ```go
   // before:
  	queryClient := kusto.New("https://ingest-somecluster.kusto.windows.net")
    client := ingest.New(quetryClient, "some-db", "some-table")

    // after:
    client := azkustoingest.New("https://ingest-somecluster.kusto.windows.net", azkustoingest.WithDefaultDatabase("someDb"), azkustoingest.WithDefaultTable("someTable"))
  ```
* Added autocorrection for endpoints for ingest clients. When creating a client, the "ingest-" will be added or removed as needed. To avoid this behavior, use the `azkustoingest.WithoutEndpointCorrection()` option.
* ManagedStreamingClient constructor now only requires the query endpoint, and will infer the ingest endpoint from it. If you want to use a different endpoint, use the `azkustoingest.WithCustomIngestConnectionString()` option.
* Removed the old deprecated Stream() method on queued ingest client, instead use azkustoingest.NewStreaming() or azkustoingest.NewManaged() for proper streaming ingest client.
* Removed `QueryIngestion()` option for Query client. If you want to perform commands against the dm, create a query client with the "ingest-" endpoint.

* Tests and docs

* More tests

* fmt

* fmt

* Try to improve build errors

* f

* f

* Try again

* Try again

* Try again

* Fix

* Update README.md

Co-authored-by: Yochai Gilad <[email protected]>

* Update azkustoingest/common.go

Co-authored-by: Yochai Gilad <[email protected]>

* Rename

* Remove queryclient

* Remove queryclient

* Remove queryclient

* Remove queryclient

---------

Co-authored-by: Yochai Gilad <[email protected]>
# Conflicts:
#	CHANGELOG.md
# Conflicts:
#	CHANGELOG.md
#	quickstart/go.mod
@AsafMah AsafMah changed the title Split & rename modules Future version 1.0 Nov 29, 2023
AsafMah and others added 18 commits November 30, 2023 10:09
# Conflicts:
#	go.mod
#	go.sum
#	kusto/test/etoe/etoe_test.go
#	quickstart/go.mod
#	quickstart/go.sum
# Conflicts:
#	CHANGELOG.md
#	azkustoingest/file_options.go
#	azkustoingest/internal/properties/properties.go
#	azkustoingest/internal/queued/queued.go
#	azkustoingest/internal/queued/queued_test.go
#	azkustoingest/internal/utils/ingestion_utils.go
#	azkustoingest/managed.go
#	azkustoingest/streaming.go
#	kusto/test/etoe/etoe_test.go
# Conflicts:
#	azkustoingest/internal/resources/ranked_storage_account.go
#	azkustoingest/internal/resources/ranked_storage_account_set.go
#	azkustoingest/internal/resources/ranked_storage_account_set_test.go
#	azkustoingest/internal/resources/resources.go
* Frame definitions

* Working json (kinda)

* Improved values

* Improved values

* Improved values

* Compilation errors

* More fixes

* meanwhile commit

* merge from main

* Reworked kusto types -
No more duplications between packages.
Removed old system of query building.
Fixed tests, etc.

* Query v2 - tables, frames, all

* Added query

* More tests

* Working tests

* More tests

* Something is off

* Something is off

* Fixed error

* More tests, more tables

* Fixed tests, aligned types, etc

* -int types can be deserialized to struct (with error on overflow)
-fixed secondary tables

* Easy row consumption and op for errors

* Some docs

* Examples and tests

* Fixed tests

* Fixed data races. Removed fixed table (for now)

* Fixed deadlock + parallel tests

* Fixed deadlocks

* Fixed deadlocks

* Rework tables into results

* Big refactor - split common data from v2 specific

* More v1 stuff

* More v1 stuff

* Moving stuff around for compile errors

* Fixed tests

* Fixed recursive lock issue

* Fixed recursive lock issue

* Fixed recursive lock issue

* Fixed missing break

* Fixed missing break

* Fixed test

* Make sure the correct error is always called, without race condition

* Make sure the correct error is always called, without race condition

* Make sure the correct error is always called, without race condition

* upgrade

* Merge fixes

* Merge fixes

* Tests and fixes

* Tests and fixes

* Split v2 tables to streaming and non-streaming

* Fixed tests

* Renames

* Fixed error

* Renaming

* More api and partial results test

* Fixed read

* Some docs

* -Renames and add apis
-Fixed partial Results text
-Fixed full errors tests

* full dataset tests

* Fixed tests

* Handle partial errors in v2 & fixed number handling in v1

* Naming and comments

* PR fixes

* PR fixes

* Added error description and table progress

* Added error description and table progress

* Fix tests

* PR fixes

* Fix tests

* Removed more old code, fixed tests, still wip

* Fixed all tests

* Fixed + added benchmark

* Fixed ingest tests by relocating mock

* Fixed tests

* More fixed tests

* Fixed race

* typo

* remove todo (for now)

* Cherrypick changes from other branch

* -Simplify and rename

* PR Changes:
- Simplify code to handle only what needed
- Rename ordinal to index
- Some comments

* Fixed samples

* Fixed cycle

* Removed old full dataset things

* Renames and bug fixes

* Aligned types, made full tables make more sense.

* Properly close tables, fixed deadlocks and tests.

* Fixed ingest tests

* Fixed test

* build.yml

* Updated sample app

* Improve allocations and fix benchmarks

* Improve values system

* -Reduced code dups in structs
-Fixed edge cases

* Jsontest - correct order of params

* cache decodeToStruct result

* PR stuff

* PR stuff

* PR changes - part 1

* PR Changes - renames

* Readne

* Lock Cache
* Bump golang.org/x/crypto from 0.14.0 to 0.17.0 (#219)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
- [Commits](golang/crypto@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /quickstart (#218)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
- [Commits](golang/crypto@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Changed just sstream to false. the rest was fine (#220)

* Update issue templates (#223)

* Update build.yml

* Update build.yml (#224)

* T ronmoneta/compression auto detect fix (#222)

* Changed just sstream to false. the rest was fine

* Switched rows

* New doc files and Migration guide

* Update MIGRATION.md

Co-authored-by: ohad bitton <[email protected]>

* Update MIGRATION.md

Co-authored-by: ohad bitton <[email protected]>

* Update MIGRATION.md

Co-authored-by: Yochai Gilad <[email protected]>

* New doc files and Migration guide

* Last fixes

* azkustodata tidy

* version fixing

* version fixing

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: t-ronmoneta <[email protected]>
Co-authored-by: ohad bitton <[email protected]>
Co-authored-by: Yochai Gilad <[email protected]>
# Conflicts:
#	.github/workflows/build.yml
#	CHANGELOG.md
#	azkustodata/internal/version/version.go
#	azkustoingest/go.mod
#	azkustoingest/go.sum
#	kusto/data/table/from_kusto_test.go
#	kusto/data/value/int.go
#	quickstart/go.mod
#	quickstart/go.sum
@AsafMah AsafMah merged commit 780db0e into master Mar 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants