This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Fix to make local ECDSA signature encoding compatible with service #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnature encoding
- Added static class SignatureEncoding to covert between ASN.1 DER encoded ECDSA signatures and raw signatures
- FUNCTIONALLY BREAKING CHANGE: Signatures created with local ECDSA keys from previous versions os
azure-keyvault-cryptography will no longer verify properly on newer versions of azure-keyvault-cryptography.
They must first be decoded using the method SignatureEncoding.fromAsn1Der
bhicks2
suggested changes
Nov 19, 2018
...-cryptography/src/main/java/com/microsoft/azure/keyvault/cryptography/SignatureEncoding.java
Outdated
Show resolved
Hide resolved
...-cryptography/src/main/java/com/microsoft/azure/keyvault/cryptography/SignatureEncoding.java
Show resolved
Hide resolved
...-cryptography/src/main/java/com/microsoft/azure/keyvault/cryptography/SignatureEncoding.java
Show resolved
Hide resolved
...-cryptography/src/main/java/com/microsoft/azure/keyvault/cryptography/SignatureEncoding.java
Outdated
Show resolved
Hide resolved
...-cryptography/src/main/java/com/microsoft/azure/keyvault/cryptography/SignatureEncoding.java
Show resolved
Hide resolved
...t-cryptography/src/main/java/com/microsoft/azure/keyvault/cryptography/algorithms/Ecdsa.java
Outdated
Show resolved
Hide resolved
...t-cryptography/src/main/java/com/microsoft/azure/keyvault/cryptography/algorithms/Ecdsa.java
Outdated
Show resolved
Hide resolved
...t-cryptography/src/main/java/com/microsoft/azure/keyvault/cryptography/algorithms/Ecdsa.java
Outdated
Show resolved
Hide resolved
...ult-cryptography/src/test/java/com/microsoft/azure/keyvault/cryptography/test/ECKeyTest.java
Show resolved
Hide resolved
bhicks2
suggested changes
Nov 19, 2018
bhicks2
approved these changes
Nov 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure-keyvault-cryptography will no longer verify properly on newer versions of azure-keyvault-cryptography.
They must first be decoded using the method SignatureEncoding.fromAsn1Der